fix(ci): authorize visual acceptance by capability - #5594
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
force-pushed
the
fix/visual-acceptance-effective-capability
branch
from
August 27, 2026 08:21
c0abfdc to
b585189
Compare
cixzhang
force-pushed
the
fix/visual-acceptance-effective-capability
branch
from
August 27, 2026 08:26
b585189 to
e743f44
Compare
github-actions
Bot
deleted the
fix/visual-acceptance-effective-capability
branch
August 27, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#5592 normalized GitHub's collaborator-permission response but still allowed the reported role name to grant authority. Role names are provenance, not a stable capability boundary. Endpoint authorization must depend only on strict effective
maintainoradminbooleans.What
admin === trueormaintain === trueauthorizes.effectivePermissionmay use rawmaintainoradmin; legacywritefails.Risk
Low and fail-closed. This removes a mutable role-name authorization path without widening the accepted capability set.
Testing
actionlint .github/workflows/visual-acceptance.ymlpnpm check:repobe6f3351c823f6b62c59eb29507cb4518024eacc: capability path returnssuccess:accepted; role-only and raw-admin fallback attempts failNo live acceptance command was replayed.