Skip to content

docs(docsite): correct two stale backdropGlow comments left by #5415 #5467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imdreamrunner merged 2 commits into from
Aug 26, 2026
Merged

docs(docsite): correct two stale backdropGlow comments left by #5415 #5467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad96a6e
docs(docsite): correct the backdropGlow comment's causal chain
imdreamrunner Aug 25, 2026
1c5f5fe
docs(docsite): drop the stale unconditional 'fixed' from the glow's h…
imdreamrunner Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions apps/docsite/src/app/(site)/_landing/hero/HeroThemeReel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,16 +168,20 @@ const styles = stylex.create({
transition: 'background-color 600ms ease',
zIndex: 0,
},
// Blurred aurora glow — fixed, in the same 1200px box as the cards so blobs
// and cards stay aligned. Capped to 100vw to avoid horizontal scroll. Blob
// centers sit under the card clusters; colors come from --aurora-* per slide.
// Blurred aurora glow — in the same 1200px box as the cards so blobs and
// cards stay aligned; pinned at >=1024px and scrolling away with the hero
// below that (see `position`). Capped to 100vw to avoid horizontal scroll.
// Blob centers sit under the card clusters; colors come from --aurora-* per
// slide.
backdropGlow: {
// Desktop: fixed, part of the pin-and-cover effect alongside heroContent
// and the cards stage. Narrow: absolute within heroScope (position:
// relative), so it scrolls away with the hero instead of staying pinned
// for the whole page — a fixed glow below 1024px reached past the
// footer into the bottom-overscroll gap, which blocked pull-to-refresh
// from ever registering a release (#5392).
// for the whole page — a fixed glow below 1024px reached past the footer
// into the bottom-overscroll gap. That exposure is what the app-global
// `overscroll-behavior-y: none` in globals.css was suppressing, at the
// cost of pull-to-refresh on every route on mobile; bounding the glow
// here is what lets that rule scope to desktop widths (#5392).
position: {
default: 'absolute',
'@media (min-width: 1024px)': 'fixed',
Expand Down
Loading