docs(docsite): correct the backdropGlow comment's causal chain - #5467
Draft
imdreamrunner wants to merge 1 commit into
Draft
docs(docsite): correct the backdropGlow comment's causal chain#5467imdreamrunner wants to merge 1 commit into
imdreamrunner wants to merge 1 commit into
Conversation
The comment said a fixed glow below 1024px 'blocked pull-to-refresh from ever registering a release'. It never did — `overscroll-behavior-y: none` in globals.css did. The glow is the *reason that rule was written*: it was the layer bleeding into the bottom-overscroll gap, and bounding it is what lets the rule scope to desktop widths. Comment only, no behavior change. Follow-up to #5415 (issue #5392).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
August 25, 2026 02:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5415 (issue #5392). Comment only — no behavior change, no CSS change.
Why
The
backdropGlowcomment added in #5415 states the wrong cause:The glow never blocked pull-to-refresh.
overscroll-behavior-y: noneinglobals.cssdid — the glow is the reason that rule was written. That direction matters: the rule suppressed the whole page's overscroll to hide one bleeding layer, and bounding the layer is precisely what let the rule retreat to desktop widths.As written, the comment tells the next person the glow is the thing that breaks pull-to-refresh, which would send them to the wrong file. It is the durable record of this decision, so it is worth being right.
What
Risk
None. Five comment lines in one file.
Testing
prettier --checkandeslint --no-cacheclean on the changed file;check:changesetspasses (no changeset — docsite app code, not a published package, and no consumer-visible change).Opened as a draft since it is cosmetic — happy to close it if you would rather leave the comment as-is.