Skip to content

docs(docsite): correct the backdropGlow comment's causal chain - #5467

Draft
imdreamrunner wants to merge 1 commit into
mainfrom
codex/hero-glow-comment-accuracy
Draft

docs(docsite): correct the backdropGlow comment's causal chain#5467
imdreamrunner wants to merge 1 commit into
mainfrom
codex/hero-glow-comment-accuracy

Conversation

@imdreamrunner

Copy link
Copy Markdown
Contributor

Follow-up to #5415 (issue #5392). Comment only — no behavior change, no CSS change.

Why

The backdropGlow comment added in #5415 states the wrong cause:

a fixed glow below 1024px reached past the footer into the bottom-overscroll gap, which blocked pull-to-refresh from ever registering a release

The glow never blocked pull-to-refresh. overscroll-behavior-y: none in globals.css did — the glow is the reason that rule was written. That direction matters: the rule suppressed the whole page's overscroll to hide one bleeding layer, and bounding the layer is precisely what let the rule retreat to desktop widths.

As written, the comment tells the next person the glow is the thing that breaks pull-to-refresh, which would send them to the wrong file. It is the durable record of this decision, so it is worth being right.

What

- for the whole page — a fixed glow below 1024px reached past the
- footer into the bottom-overscroll gap, which blocked pull-to-refresh
- from ever registering a release (#5392).
+ for the whole page — a fixed glow below 1024px reached past the footer
+ into the bottom-overscroll gap. That exposure is what the app-global
+ `overscroll-behavior-y: none` in globals.css was suppressing, at the
+ cost of pull-to-refresh on every route on mobile; bounding the glow
+ here is what lets that rule scope to desktop widths (#5392).

Risk

None. Five comment lines in one file.

Testing

prettier --check and eslint --no-cache clean on the changed file; check:changesets passes (no changeset — docsite app code, not a published package, and no consumer-visible change).

Opened as a draft since it is cosmetic — happy to close it if you would rather leave the comment as-is.

The comment said a fixed glow below 1024px 'blocked pull-to-refresh from
ever registering a release'. It never did — `overscroll-behavior-y: none`
in globals.css did. The glow is the *reason that rule was written*: it was
the layer bleeding into the bottom-overscroll gap, and bounding it is what
lets the rule scope to desktop widths.

Comment only, no behavior change. Follow-up to #5415 (issue #5392).
@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 25, 2026 2:04am

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 25, 2026
@github-actions github-actions Bot added the needs:design-review Affects visuals — Design should review label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. needs:design-review Affects visuals — Design should review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant