chore: drop nodejs < 18 #1020
Open
chore: drop nodejs < 18 #1020
+93
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@UlisesGascon can you bring the latest changes from the master branch to v2? |
|
Ah yeah, I see it needs the commit from Chris to generate a fresh cert |
|
Yep, only you can do it since I don't have the permissions :) |
Phillip9587
reviewed
Feb 13, 2025
|
I have just left two minor comments. Also, I wanted to check—do we need to run the CI on Let me know what you think! |
Co-authored-by: Phillip Barta <[email protected]>
|
Well, this is not a lower-level package, but I don't think we want to run tests on Windows here. |
Co-authored-by: Phillip Barta <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
It should have the latest changes from that branch |
Phillip9587
suggested changes
Feb 13, 2025
Co-authored-by: Phillip Barta <[email protected]>
Phillip9587
approved these changes
Feb 13, 2025
UlisesGascon
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for old Node.js is removed, and the express CI is copied :)