Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync cert changes with v2 branch #1024

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Sync cert changes with v2 branch #1024

merged 5 commits into from
Feb 13, 2025

Conversation

UlisesGascon
Copy link
Member

Originally requested by @bjohansebas in #1020 (comment)

BaileyFirman and others added 5 commits January 22, 2025 09:21
cd test/fixtures

openssl genpkey -algorithm RSA -out new_server.key -pkeyopt rsa_keygen_bits:2048

openssl x509 -in server.crt -signkey new_server.key -days 3650 -out new_server.crt

openssl x509 -in new_server.crt -text -noout

mv new_server.crt server.crt

mv new_server.key server.key
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

fi

- name: Upload code coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
@@ -222,9 +222,8 @@
run: sudo apt-get -y install lcov

- name: Collect coverage reports
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
@bjohansebas
Copy link
Member

Can you merge this, please? It makes it difficult to review other PRs if the tests are failing due to something that has already been fixed.

@UlisesGascon UlisesGascon merged commit 3e84825 into v2 Feb 13, 2025
57 checks passed
@bjohansebas
Copy link
Member

thanks @UlisesGascon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants