Skip to content

Backport for v3.1.x: feat(uart): fixes pin attach for any IDF 5.x #11500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/v3.1.x
Choose a base branch
from

Conversation

Jason2866
Copy link
Collaborator

@Jason2866 Jason2866 commented Jun 22, 2025

Updates Arduino v3.1.x to be compatible and working with latest IDF 5.3.x

Backport of #11499 Tested with Arduino Lib Builder and resulting framework with Tasmota and provided example in #11498

Version ist still interesting to use since the resulting firmware sizes are slightly smaller and the S3 parallel LCD Display Screen Shift bug in IDF 5.4.1 is not yet solved. This issue is not in IDF 5.3.x

Copy link
Contributor

github-actions bot commented Jun 22, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Backport for 3.1.x: feat(uart): fixes pin attach for any IDF 5.x":
    • summary looks empty
    • type/action looks empty
  • the commit message "bool uartSetBaudRate()":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello Jason2866, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f9002b5

@Jason2866 Jason2866 requested a review from SuGlider June 22, 2025 15:09
Copy link
Contributor

github-actions bot commented Jun 22, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f9002b5.

♻️ This comment has been updated with latest results.

@Jason2866 Jason2866 added Area: ESP-IDF related ESP-IDF related issues Peripheral: UART bug 🐞 Inconsistencies or issues which will cause a problem for users or implementers. labels Jun 22, 2025
@SuGlider SuGlider added the Status: In Progress ⚠️ Issue is in progress label Jun 23, 2025
@SuGlider
Copy link
Collaborator

@Jason2866 - we will hold it for a couples days because there are a few more UART changes to come.
Later we can add all at one and merge it.

@SuGlider SuGlider self-assigned this Jun 23, 2025
@Jason2866
Copy link
Collaborator Author

The never ending UART changes ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: ESP-IDF related ESP-IDF related issues bug 🐞 Inconsistencies or issues which will cause a problem for users or implementers. Peripheral: UART Status: In Progress ⚠️ Issue is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants