Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WPS #331
Add support for WPS #331
Changes from 6 commits
3467d82
9b11011
2fd53ac
64128d7
54ae7e0
1256108
9e36569
2c13c11
e44255c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is correct w.r.t. ASCIIZ strings. You are not procesing the
\0
byte correctly.Also, rather than having yet another function that sets a
core::str
as an ASCIIZ C string, can you just useset_str
from above? If necessary, please make it faillble rather than asserting.Also and if necessary, please make it working without requiring the
alloc
module.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is resolved. How is this whole function you introduced any different than
set_str
? Please fixset_str
instead if it needs fixing (as in, make it not assert but return an error instead).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I did not realize that you are now calling
set_str
. Still, why is your function necessary? If it is just to re-cast&mut [u8]
to&mut [c_char]
can you please do it in the calling code instead?