Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for WPS #331

Merged
merged 9 commits into from
Dec 21, 2023
Merged

Add support for WPS #331

merged 9 commits into from
Dec 21, 2023

Conversation

thetek42
Copy link
Contributor

No description provided.

torkleyy
torkleyy reviewed Dec 20, 2023
View reviewed changes
examples/wps_async.rs Outdated Show resolved Hide resolved
src/private/cstr.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
ivmarkov
ivmarkov requested changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@ivmarkov ivmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. Some small polishing suggested in terms of API as well as internal Cstr processing.

src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
src/wifi.rs Show resolved Hide resolved
src/wifi.rs Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
@ivmarkov
Copy link
Collaborator

@thetek42 Once you remove the pesky set_cchar_slice the PR should be good to go. Rest is OK.

@ivmarkov
Copy link
Collaborator

Thanks!

@ivmarkov ivmarkov merged commit 2aab27a into esp-rs:master Dec 21, 2023
8 checks passed
@thetek42 thetek42 deleted the wps branch December 21, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivmarkov ivmarkov ivmarkov requested changes

@torkleyy torkleyy torkleyy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thetek42 @ivmarkov @torkleyy