Conversation
Keep synchronization scenarios with their correction in ergoplatform#2511. Reuse the spendable sorting fixture already present in ergoplatform#2480.
Move the exact UtxoStateNodesSyncSpec correction from ergoplatform#2511 into the shared test-support prerequisite. Preserve topology, height and the deadline while observing eventual agreement of selected headers; retained sibling IDs are not selected-chain disagreement.
This was referenced Sep 10, 2026
a-shannon
marked this pull request as ready for review
September 10, 2026 05:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallet transaction and scan queries can return transactions below the requested minimum confirmation count because the upper height bound omits the current chain height. The fix derives inclusive bounds with
Longarithmetic and skips empty or inverted database ranges.At height 100, a request for 5 to 10 confirmations now selects heights 90 through 95. Requests beyond the available history return an empty result. The existing confirmation convention, scan selection, descending order and unconfirmed-transaction height gate are preserved.
The current head is
8c91586dbd0d5172b0b3da0e56af471177fe992e. It merges the exact shared test-support commit5eedfdc91d7a515f66822643e730b4ca9b3197dffrom #2535, including the complete, non-mining shared seed before rollback miners are isolated.ErgoWalletActor.scalaandWalletConfirmationWindowSpec.scala.Independent composition review completed without findings. Local validation was performed in separate runs:
Linux CI for the exact current head passed all eight required checks. This revision is ready for maintainer review. The separate passing local runs do not establish that the full native Windows suite is healthy.
The previous CI run at
e3489d0cfpassed seven of eight checks; integration passed 12 of 13 cases and timed out inDeepRollBackSpec. That is historical evidence, and the shared seed update does not establish the cause of that timeout.This query correction is independent of the registry-write changes in #2514 and #2516.