Skip to content

Tracking: node corrections, review priorities and integration dependencies #2533

Open
Open
Tracking: node corrections, review priorities and integration dependencies#2533

Description

@a-shannon
a-shannon
opened on Sep 7, 2026

A. Shannon's public contribution tracker. Start with the Matrix review lanes below; release priorities and detailed evidence follow.

Matrix / subblocks: independent reviews wanted

Who can help? Scala/Akka, P2P, mining/transaction, wallet/state and CI reviewers can take one unit below. Comment on its PR with the commit, review scope, findings and tests run. No individual is assigned; maintainers retain merge/release decisions.

20 September snapshot: 12 open Matrix PRs by A. Shannon, including 7 drafts and 5 non-drafts; no outstanding GitHub reviewer requests. Eleven have 8/8 successful checks. #2502 has 7 successful checks and one cancelled Scala 2.11 core job; node/integration jobs passed. CI success is separate from review approval. Current heads, checks and per-PR actions.

Your area First bounded review Question to answer
Scala/Akka; small starting point #2505: typed mining-solution forwarding, two files Are both typed solution variants forwarded with the original sender, without changing proof acceptance? The REST-route correction is a separate part of #2505.
Build/CI #2501: pinned Sigma bootstrap, then Scala compatibility Do source pins, declared snapshots and each consuming Scala version agree? Review shared build support once, before dependent execution checks.
Protocol commitments #2368: declared-field/proof binding; #2367: previous-transaction digest Do the values used by validation match the authenticated leaves and the correct transaction prefix? These are two separate review units.
P2P / actor lifecycle #2500: ID-response admission; #2503: pending-state bounds; #2506: idle-peer replay Pick one: expected-peer admission, accounting release on terminal paths, or replay of the processed tip without pending descendants.
Mining / transaction accounting #2504: selection and ordering fees, then candidate-cache identity Check version-dependent partitions, dependency deferral, fee/size limits and cache invalidation when the accepted input prefix changes.
Forks / wallet / mempool #2502: rollback propagation, then available-prefix/conflict cleanup Are abandoned blocks and wallet/mempool effects restored in the right order, including missing-cache and late-body cases?

Review order versus integration order: these are parallel review lanes, not one PR chain. Start with an owner commit, then reconcile it with the pinned current PR head and later tests; a cumulative PR diff includes other owners' work. For shared synchronization, review #2535's reader fixture before #2511's V2 synchronization change. #2549's cache wake-up is merged into v6.0.6; its presence on weak-blocks must be checked separately. Review #2505's complete three-node lifecycle after its build, mining, rollback and synchronization prerequisites.

Next actors: volunteers review; A. Shannon addresses findings, isolates unclear diffs and confirms which drafts to mark ready; maintainers select adoption and integration. Resolve #2502's cancelled job. Separately, #2554 is approved but policy/Sigma CI remain open; its author owns the nonblocking cross-peer test.

Latest updates

Proposed release priorities

For 6.0.6, maintainers prioritize #2496 and P2P. #2424 now targets v6.0.7 following the request to move it off master; reviewed feature ownership and deferred combined integration remain unchanged.

Review and integration now

Suggested review order outside Matrix: review the isolated reader fixture from #2535 before #2511 synchronization, then the remaining shared test support; use the linked increments below. #2549 is merged into v6.0.6. The reader fixture also precedes #2433. Integrate approved #2507 before #2543; the wallet-only history has no #2535 dependency. #2421 is independent of #2496; #2432 is already merged. #2520 precedes #2479 on a common line. Preserve approved heads until their integration needs a change.

Priority / queue Owner Action
P2 synchronization prerequisite merged #2549, v6.0.6 X merged; #2535 still needs its remaining prerequisite/review closure. Fork #2 already carries X and stays deferred. Other targets require their own ancestry check; no bulk rebase or CI rerun follows from this merge.
P2P review follow-up #2421; #2432 merged Maintainer: review #2421. #2432 merged into v6.0.6 on 14 September. The retained composition proof passed 18/18; check the actual target ancestry and preserve both fixes.
P1 already assigned upstream Storage-rent issue #2251: draft #2438 supersedes closed #2375 Preserve the gated arithmetic/legacy compatibility decision in #2438; no approval or activation is implied. Separate from the P2 persistence queue.
Conditional P1 recovery, deferred with #2424 #2424 startup failure handling Begin later review at restoreState: failed recovery requested asynchronous shutdown then returned None, allowing getOrElse(genesisState) to attempt state-directory recreation. Deletion/wallet/history loss is unproven. Introducing commit is larger, not a standalone small PR. Full #2424 follows #2535/#2511.
P2 persistence review #2542 stores; #2541 history; #2543 wallet initialization #2541/#2542 retain prior 8/8. #2507 now has three files; direct #2543 typed-absence composition passed 4, POSIX case conditional. #2543 was not rebased.
Approved heads #2518, #2527, #2520 c9ddcaaa5; #2507 15a1e04c5 Maintainers select integration. #2507 was approved at this head on 14 September; #2432 is already merged. Preserve #2510 interactions and approved heads. Other entries retain their dated observations.

#2520's current head was approved by jozanek on 14 September; #2479's separate CI timeout does not invalidate it. #2507 also has exact-head approval at 15a1e04c5; its older 1452249f approvals remain historical.

Detailed review evidence, compatibility and historical validation

Recorded-remediation campaign

Eight proposals cover nine recorded items: HTTP binding/draining share one correction. Author follow-ups add no discovery counts. No new P0/P1 or irreversible-loss claim. #2537–2542 retain evidence; #2543 checks are separate.

PR / scope Head and exact review increment Current checks / next action
#2542, P2: versioned data/undo/version/retention a88c3ef9f; increment; #2519 + #2535 8/8. Local 72 storage +15 snapshot +20 consumers +3 workload cases. Back up all three DBs; no old writers/raw-DB coverage or retroactive legacy repair. Four synchronous writes per transition; synthetic timings do not establish production performance/power-loss recovery.
#2541, P2: paired history insertion 223ea95c6; increment; #2535 at b3ebc6d6 8/8. Storage 33 + header serialization 18/routes 10 passed; header bytes/IDs unchanged. Existing unjournaled orphans and other history mutations remain outside scope.
#2543, P2: wallet initialization 13cf1a252; owning increment includes older #2507 f17d145d6; C2 merge retained. Prior 8/8, CI,54-case closure/four negatives. New #2507 typed-absence composition:4 passed,1 POSIX conditional; no rebase. API/unknown-activation, backup-generation and no-old-writer limits remain.
#2536, P2: wallet confirmation windows 8c91586dbd0d5172b0b3da0e56af471177fe992e; wallet correction, shared-fixture composition 8/8, run 34422335035; ready for review. S imports ten fixture files with no production changes or #2511 production dependency. Local 32 pure tests passed; 70 cases completed before a Windows native LevelDB crash in the full holder suite, followed by a fresh five-wallet/four-targeted-holder pass. Current Linux CI is green; prior e3489d0cf timeout remains historical.
#2537, P2: REST bind/drain lifetime 2a9fc13b1; current increment, prior reviewed increment; #2535 at e18df9692 8/8, run 34296897482. Four HTTP-owned files unchanged; local 6 lifecycle +1 sorting passed. Prior 0d37a1601 Maven403 stopped wallet tests (5 success/2 cancelled/1 failed); that head's maintainer-rerun request is historical.
#2538, P2: indexed/mempool UTXO pagination ff98299b1; increment 8/8; local 6. Preserve indexed direction/mempool order; independent query review.
#2539, P3: indexed-block OpenAPI contract 21ca73ed7; increment; #2535 at b3ebc6d6 8/8; one YAML file, parse/reference/source checks; runtime JSON unchanged.
#2540, conditional P3: mining-worker polling c3209fcf5; increment; #2535 at b3ebc6d6 8/8; local 2. Worker ownership is distinct from #2530.

Existing-author follow-ups

PR / target Exact increment Status / remaining obligation
#2544 follows #2362, target wallet-pruning-prevention at 5b27cd70c ce50cc3ab; current, cleanup review, image step, test backport 8/8, still draft; attempt 2 passed on the same head. Attempt 1 had a 15-minute ForkResolution timeout, 12/13 run and one ignored; cause remains unestablished. Cleanup 5 + backlog 1 and Autolykos 4 passed locally with independent review. Backports from #2373/#2291 and #2294 b1739cb5 remain subject to parent adoption. Retry needs a later eligible block; below-floor migration is separate. No #2523 index-removal dependency. Owner review of #2362 composition remains required.
Ergologica/ergo#1, target #2466's feat/persist-unconfirmed-wallet-txs-1154 at 090fc7cf 79a79bfe8; increment 0 checks; owner action required. Local 12 passed. Retention and actual-success cleanup are preserved in the compatibility reviews below. Input reservations for retained transactions absent from the mempool follow #2466's existing promise; Invalidated policy is unchanged and remains a separate decision. Upstream integration still needs the owners' review.

Wallet compatibility reviews on the contributor fork

These reviews retain #2409/#2424/#2466 ownership. Native stacks need one repository; cross-fork joins use pinned comparisons. Stack only real dependencies.

Review Scope and evidence Current action
a-shannon/ergo#1, projection/persistence Head 090a27db8dd30d60fecb8cb36601236c2decd930; increment, base retention follow-up 79a79bfe8. Preserve accepted-transaction persistence, reserve durable inputs separately, and keep outputs/balances current-mempool-derived. Local 26 wallet +16 candidate cases pass; independent review complete. 8/8, ready for review, run. Existing #2409 projection is included as a prerequisite. Candidate fixture follow-ups reuse #2535's exact helpers and fixed-reader force-cache case; production is unchanged by those test fixes.
a-shannon/ergo#2, snapshot/wallet join 033992019 on #2424 c9c6b760c; 26 files, +2737/-440. X increment; full comparison below. 8/8, IT 50/50; both holder cases passed, independent review clear. Historical failures remain below.

Restoration waits for operational wallet alignment through one correlated request and a coalesced guard recheck. Actor restart reuses the pending holder UUID; foreign/stale replies cannot enter admission. At most one response is accepted per holder incarnation.

Projection is materialized after copies/readers update, before rollback/snapshot/quarantine guards clear. Dust-limit None and scan-refreshed reservations persist. Cases cover catch-up, delayed alignment, restart and reader/reservation failures. TTL/Invalidated are unchanged; injected failures and candidate-store shutdown diagnostics remain. No general crash/power-loss or clean-teardown claim.

Bootstrap ownership: #2496 now contains #2545's ordinary-header behavior; #2545 closed as superseded. #2546 owns D01 Digest checkpoint/receive and storage read-back; #2424 owns deferred wallet adaptation. The historical audit retains 34 findings; D01 is separate.

Ordinary-bootstrap and Digest snapshot review limits

Review shared R before G, without requiring full #2535 before #2511. #2546 no longer waits for #2545, whose behavior is in current i2464; #2424/combined stay deferred. #2496 owns ordinary bootstrap; Jozanek review was COMMENTED, not approval.

Current #2546 targets i2464 with its own isolated diff; superseded #2545 is closed. #2424/combined retain older adaptations and must incorporate the new snapshot increments at their integration step. #2531 already covers C12 selected-header cache filtering.

The receive fixture uses a 32,768-box snapshot at production manifest depth 14 with nonzero detached chunks. Serialized messages pass through the production synchronizer and real chunk persistence to an InitStateFromSnapshot probe. Direct manifest/request registration does not prove TCP negotiation or full state import; separate producer/wallet fixtures cover their stated import/output boundaries.

Still unqualified: interrupted/partial downloads, process-crash recovery, restart without fresh headers, proof trust/genesis gates, penalties and mainnet it2. General it:test CI does not qualify these. The tested Digest representation/reopen boundary is corrected; separate #2496 history-restart/proof-verifier changes remain excluded from #2424/combined. Keep #2464 open until its claimed scenario is supported; review threads remain unresolved.

Shared ownership, pinned increments and integration

Shared ownership: historical master S1 5eedfdc91 / S2 99f8bd2ff remain the exact prerequisites of existing #2511/#2536 and #2424/combined consumers. Preserve descendants until integration requires refresh. S1 retains a complete/non-mining tip, two-minute setup bound, seed below 50, targets 50/200 and deadlines 20/10 minutes; it is neither a P0/P1 nor a proven cause of earlier timeouts.

Review unit Pinned history and current action
#2535 shared support efbd1e91: 14 owned support files, 22 cumulative with G/X prerequisites; 49/49 local. R increment reused by #2433 and G; C2 ancestry unchanged. Prior 148 cases and historical master/S2 (+13/-8, 26 cases, same deadlines)/8/8 CI retain scope.
#2511 synchronization 8c00df3a: R reader fixture only, actual 47/47 and native 8/8; G production unchanged. History proof: prefixes3/18, tips9/13 and249/70, both directions. Historical S1 increment/8/8 retained.
#2523 storage/callers Storage/direct tests 21ce380ef, then callers 974c98d51, atop original support. Historical8/8. #2424's whole feature is not prerequisite; snapshot methods remain there.
#2514 then #2516 Maturity b41 is 8/8. Registry 2b529 retains real b41 + D/X/G/K and four owner files; local133 then37. Current7/8: node dependency resolution before tests; IT passed. Administrator rerun requested. Prior459 Deep/Fork20/22 remains historical.
#2525 settings Settings-only increment 3c4105132, atop original support. Historical8/8; keep its pin until actual prerequisite merge.
#2513 state recovery bb43ed4dd, 8/8; all6 files, Digest-only increment from f1cfeea3a. Earlier reviewed c7a2fd34899d86dc77332b8a0e0f31e5193324bb retains four unchanged owned files. Local 8 current; prior38 belongs to c7. Constructor equality limits prior impact; no inconsistent-success/P0 claim. #2277 owns separate already-current rollback.
#2543 review continuity Original/cache ca61ce544; prior fe6f15e20 on ec1929a87. Typed inventory correction atop f17d145d6; C2 merge changes five shared IT files only. Prior 49 cases/8/8 remain historical.

Historical #2535 b3ebc6d6 run failed the immediate selected-header assertion while peers disagreed. Later bounded observations replaced that assertion. This historical fixture failure does not establish a production cause.

Other dependency and overlap obligations

Maintainer follow-ups: published corrections and remaining gates

PR / review Published correction / remaining gate
#2421 review 59f87747: foreign-network test, guard explanations and cleanup scope published. D/H/R/G published,94 local; threads remain unresolved.
#2432 merged Merged into v6.0.6 on 14 September. Reviewed head 810843cdf, CI 8/8, local 15 controller/25 affected cases and mutants retained. Any other-branch forward port needs a separate ancestry check; #2421 remains a separate review.
#2520 follow-up c9ddcaaa5: approved, 8/8; local19/19, reconstruction negative, measured retention and independent review. Prior composition48/48 remains historical. Reviewer separately flags a pre-existing possible double-fee path; reachability unverified, nonblocking.
#2507 approved 15a1e04c5: approved by jozanek on 14 September; 8/8. One wallet-only commit/three files, no #2535 dependency. Retained 39-case/three-negative evidence and #2543 composition 4 passed/1 POSIX-conditional remain scoped; maintainer integration is next.
#2535 target / native stacks Historical release increment; G/X precede remaining support. Native stacks require same-repository branches/upstream access.

Use each row's current CI and approval state to select the next gate; published code alone does not establish either. #2424 stays deferred. Maintainers select releases and forward ports.

Actionable review follow-ups and historical evidence

Follow-up Retained obligation
#2508 scheduler comment Last observed unresolved/outdated; code corrected in #2511 and retained in #2508 / #2509 / #2528 / #2529 / #2424. Maintainer re-review remains required. #2514's synchronization inclusion was removed. The correction preserves the forward ceiling while extending retained-ancestor lookup: 20 distinct focused #2511 tests and 12 bootstrap-variant #2424 tests passed. Thread resolution was not performed.
API policy #2385 / #2398 Earlier #2374 question was answered by separating authentication changes. Decide the two optional authentication contracts before integration; this is not a new unanswered request on #2374.
AVL Rust #12 coverage question Earlier inspected branch included #13's conservative lookup and more persistence lifecycle tests. Update its description/dependency account. Complete lazy-subtree coverage remains unestablished; code presence is not runtime evidence.

Historical evidence:

Integrated #2512: merged into v6.0.6 on 8 September 2026 at 08:39 UTC, merge 8995ff243b140e7fe716bd3204423dd35690c2e4; PR head d4a509121e4f2b0abba3db96afe9ebabf43ede72 was an exact seven-file port. Eighteen focused release tests and run 34198630972 (8/8) passed. Formal jozanek/kushti approvals refer to 2f005d3bc00e78f6ac83e9aa3d41cd1c7629acb3. Branch integration is not release publication.

A. Shannon owns refresh/conflicts/validation; maintainers own review/merge. Preserve reviewed heads, approval pins, target tracks and pinned increments.

Historical CI: old Java/setup and convergence failures remain at their original PR heads, including #2535 run 34730855804. Later green heads supersede only their own gates, without proving one exclusive failure cause.

Historical release proof: fork #3 retained 47 local and Docker 51/51 +1 ignored (run); later 49 local/8 CI checks are covered by #2535 efbd. Fork #3 closed unmerged; its history is retained, not an upstream merge.

Historical failures: #2514, #2516 and #2529 had IT failures on older heads. Read current rows before acting on those logs.

Historical composition evidence: #2549 IT 22/22 and fork #2 IT 50/50 were green; earlier combined run 34727875148 had readiness/setup failures. Current rows supersede old action requests, not the retained observations.

Shared review ownership: #2535 owns reader/observation fixtures; #2511 owns synchronization/cache/scheduling; #2549 owns cached-section wake-up. Review the reader fixture before synchronization and each owner once before its consumers. #2549 is merged into v6.0.6; other target ancestry still needs checking. Exact comparison links and historical consumer checks remain in the owner tables and PR descriptions.

Matrix shared support: #2501 owns Sigma bootstrap, Scala compatibility and mining/funding fixtures; #2504 selection/cache; #2505 typed forwarding; #2500 ordering-proof tests. The shared fixture commit is reused through ancestry. Source-equivalent evidence retains its original inputs; combined or historical counts do not certify a new head.

Remaining observed gates: #2504 99104f519 now has 8/8 CI; production review remains. #2507 15a1e04c5 is approved, awaiting integration. #2502 still has one cancelled Scala 2.11 core job after GitHub's six-hour limit, with no test results after settings reload; node and integration jobs passed. The stall cause is unproved. #2402/#2516 requests retain their older observation dates.

Full tracked inventory

20 September inventory, adjusted for #2545 closure and #2559 merge: 114 open entries across 21 repositories: 87 upstream node PRs (60 master, 6 v6.0.6, 6 v6.0.7, 1 testnet60, 12 weak-blocks, 1 wallet-pruning-prevention, 1 i2464), 22 other Ergo-related and 5 other-project PRs. Public account totals: 191 PRs, including 77 closed (42 merged, 35 unmerged). Other membership retains the earlier inventory observation.

Freshness: open membership and account counts checked 20 September. Matrix heads/checks/drafts/reviewer requests, #2432, #2507 and #2559 were refreshed; other detailed rows retain earlier observations. #2496/#2554 are other authors' PRs, outside these totals. R=review required; A=approved; C=changes requested; D=draft; NR=unreported; API=GitHub aggregate state. An aggregate state is not an exact-head approval.

Only established dependencies define order; triage labels require scope/target review. Resolve failed/cancelled/missing checks before integration. Exact runs remain in PR CI tabs and pinned history.

master: 60 tracked PRs
PR / purpose Review Head / approval Reported CI Next action
#2543: Prepare wallet generations before selecting initialized state R 13cf1a252 8/8 Validated f17d145d6 production; exact C2 merge preserves 54-case wallet closure
#2542: Coordinate versioned-store transitions with a recovery journal R a88c3ef9f 8/8 Review coordinated transitions, adoption and backup limits
#2541: Recover paired history insertions before exposing stored objects R 223ea95c6 8/8 Review paired insertion recovery and header-size consumer; no unjournaled repair claim
#2540: Cancel internal miner polling when its worker stops R c3209fcf5 8/8 Review worker lifetime; distinct from #2530
#2539: Align indexed block response schema with emitted JSON R 21ca73ed7 8/8 Review schema contract; runtime unchanged
#2538: Paginate confirmed and mempool boxes as one sequence R ff98299b1 8/8 Review combined pagination ordering
#2537: Own REST binding and drain requests before closing dependencies R 2a9fc13b1 8/8 Shared-test composition; HTTP 4 unchanged; maintainer review
#2536: Apply wallet confirmation filters within valid height ranges R 8c91586db 8/8 Ready for review on preserved S1, without S2. Shared S1 imports ten fixture files, no production or #2511 runtime dependency. 32 pure tests pass; current Linux CI supersedes the prior timeout and completes the gate left open after the local native-holder crash.
#2532: Update bundled panel with mnemonic restore warning R 161a108e7 8/8 Review with interface #65
#2531: Restore durable ExtraIndexer checkpoint recovery R 342e718e7 8/8 Sync prerequisite; indexer recovery
#2530: Cancel network periodic tasks with their owning actors R a52871a2a 8/8 Scope triage
#2529: Serve retained headers without requiring their block bodies R 561e5c3a4 8/8 Exact T/K published; IT compilation 42/42, owned code unchanged. Old072 Fork/UTXO failures historical
#2528: Bind delivery expirations to their active request attempt R 9f76f4cb5 8/8 Follow-up pushed; maintainer re-review
#2527: Preserve valid box selections across optional consolidation A 7bd94a6ea; approved at this head 8/8 Integration queue; preserve approved head and check merge requirements
#2526: Remove mempool conflicts for every applied transaction R ef1d93794 8/8 Mempool overlap group
#2525: Preserve effective wallet keystore directory configuration R 3c4105132 8/8 Review settings source and direct specification after #2535
#2524: Propagate snapshot writes and protect all retained content R 03f8ce889 8/8 Scope triage
#2523: Propagate history repair failures before publishing recovered state R 974c98d51 8/8 Review included storage correction, then caller increment; no whole-#2424 dependency
#2522: Propagate wallet unlock migration failures R b95b7072e 8/8 Wallet overlap group
#2521: Publish wallet state context after successful persistence R f059ec4ec 8/8 Wallet overlap group
#2520: Budget complete serialized transaction sections during candidate assembly A: current head c9ddcaaa5 8/8 Approved by jozanek 2026-09-14; preserve head for maintainer integration. Separate possible double-fee path unverified.
#2519: Release snapshot acquisition locks and preserve cleanup errors R f3b763077 8/8 Scope triage
#2518: Bind minted token identity to the final selected input A 114add1cf; approved at this head 8/8 Integration queue; preserve approved head and check merge requirements
#2517: Complete mempool cleanup jobs and discard stale results R a6a3225e3 8/8 Mempool overlap group
#2516: Keep wallet scan metadata, caches and write acknowledgements consistent R 2b529f736 7/8; 1 failed Registry corrections and #2514 maturity parent retained. Prior node dependency resolution failed before tests; administrator rerun request remains forwarded.
#2515: Preserve applied blocks through recursive chain fallback R 7fa13e88a 8/8 Scope triage
#2514: Keep mining reward maturity in the block wallet checkpoint R b41a94ca3 8/8 Maturity unchanged; H/D/R/G/X; combined descendant 133 local. Integrate before #2516
#2513: Propagate state rollback failures and verify recovered roots R bb43ed4dd 8/8 Review Digest increment; earlier AVL/UTXO four owned files unchanged
#2511: Restore V2 fork synchronization and block-download progress R 8c00df3a9 8/8 R before G; 47/47 local. External devnet report: 8/8 switches, 4/4 reverse controls; v6.0.5 stalled 9/13. Reported, not rerun here.
#2510: Apply automatic token burning to selected input surplus R 0748f1a09 8/8 Selector overlap group
#2509: Apply upcoming parameter changes only at voting epoch boundaries R dc9f7e6fe 8/8 Follow-up pushed; maintainer re-review
#2508: Unlock wallets with their persisted cipher parameters R 8af2db915 8/8 Follow-up pushed; maintainer re-review
#2507: Propagate wallet secret-file persistence failures A:jozanek 15a1e04c5; exact-head approval 8/8 Maintainer: integrate the approved wallet-only correction before #2543; preserve its composition evidence. No #2535 prerequisite.
#2499: Ship loopback REST defaults and require a non-default API key D/API:R; re-review 84f6088ba 8/8 Exact R then G published; actual synchronization47 passed. REST implementation unchanged. Prior connected249/70 rollback stall remains historical; no exclusive-cause claim.
#2498: Clarify rule 414 validation failures without registration changes D/R b326687b1 8/8 Author preparation; Scope triage
#2437: Preserve snapshot chunk retry budget R b9fde2796 8/8 Retry overlap group
#2436: Handle fragmented and coalesced handshakes R bee31d391 8/8 Scope triage
#2435: Enforce the global modifier download limit R 82e733f17 8/8 Scope triage
#2434: Retry snapshot manifests with GetManifest R 74e7d79f8 8/8 Scope triage
#2433: Resume missing-parent recovery for cached headers R c261bb188 8/8 #2535-owned R; one resolved fixture, assertions/deadlines retained; compile and 47/47 and fresh review clear
#2411: Avoid duplicate PoW validation for mined candidates R 1fa1076e9 8/8 Owner unchanged; 49+2+33 local. Store-lock first exit retained; fresh pair/IT green
#2405: Reject trailing P2P modifier bytes R c79e00e59 8/8 Scope triage
#2404: Reject trailing P2P message payload bytes API:R; re-review 0d22182f8 8/8 U/T and focused common J published; final candidate20 passed without ignored cases. Prior d994 IT passed and node831/832 failed only forced-cache fixture. J reuses reviewed support, not the whole #2384 feature.
#2403: Limit block header id batches R 62e78a406 8/8 Scope triage
#2402: Reject trailing transaction bytes R 8a74e9a9f 5/8; 1 failed; 2 cancelled Prior wallet setup failure and cancellations are separate from passing node/IT jobs. Administrator rerun request remains forwarded; no replacement source change inferred.
#2400: Reject trailing bytes in ErgoTree route filters R 71b1c2a4b 8/8 Scope triage
#2399: Reject trailing bytes in utils conversions R 1f5bc9e83 8/8 Scope triage
#2398: Protect UTXO binary proof route R b63cb3686 8/8 Master refresh; original two-path increment unchanged; compile and 10/10
#2397: Generate valid wallet user scan ids in tests R ccc421cb1 8/8 D/G/X after T/U/H retained; selected49 local. Wallet generator owner scope unchanged.
#2393: Validate wallet external box bindings R 24f047ea3 8/8 K/H published; wallet unchanged; IT compilation 37/37. Old Fork timeout historical
#2390: Validate wallet request token ids R 617365b47 8/8 Scope triage
#2389: Validate fixed-size byte JSON codecs R ad6de0515 8/8 Codec paths unchanged; exact 7c753 support: 8 files, +325/-78; 83/83 local; maintainer review
#2385: Protect documented script API routes R aa045bc9b 8/8 Scope triage
#2384: Validate peer connect port input R fcc7729a0 8/8 Peer-route correction retained. Its reviewed candidate fixture supplies exact common J; review J once without making this whole feature branch a prerequisite.
#2382: Validate blockchain API paging parameters R c3012cbc3 8/8 Master refresh; original two-path increment unchanged; compile and 7/7
#2378: Harden mempool fee weight arithmetic R 52837caf3 8/8 Native 8/8; arithmetic unchanged; H/D/R/G/X82, prior owner38 reused
#2377: Harden wallet amount validation R 73540835f 8/8 Scope triage
#2374: Harden REST API input validation R 9b3027038 8/8 Native 8/8; API unchanged; H/U/D/R/G/X82, prior API/shared132 reused
#2304: Docs: Comprehensive Tor Manual & JVM NIO SOCKS Bypass Disclosure (Closes #970) R 3f8e8f360 0 checks Documentation scope; absent CI remains zero checks, neither green nor pending.
#2303: Mempool: Enable CPFP via dataInputs (Closes #1156) R de4bb2b63 8/8 Scope triage
Existing-author node branches: 2 open follow-up PRs, plus merged #2559 and superseded #2545
PR / purpose Review Head / target Reported CI Next action
#2545: Resume UTXO snapshot discovery after ordinary header synchronization Closed, superseded 036c2c258; behavior included in i2464 ff4d9a180 Historical 8/8 No merge required. #2546 now uses the target implementation and current startup tests.
#2546: Preserve Digest state across snapshot bootstrap and restart Review updated increment 02ae9072e; target still i2464 6 passed; node and integration failed Snapshot fixtures pass Linux. Existing node case fails CI, local retry 4/4; integration 21/22, DeepRollBack timeout. Targeted rerun requested. #2496 merged separately; release target pending. Diff.
#2544: Preserve retry progress when block cleanup fails D/NR ce50cc3ab; target wallet-pruning-prevention 8/8 Still draft; owner review of #2362 composition and backports. Prior timeout historical; no below-floor migration
#2559: Discard stale transaction rejections after candidate retry Merged; approved by odiseusme and kushti f002151d2; merge 146aa7ac7 into #2557 8/8 at reviewed head #2557 also merged into v6.0.6. No further action on this PR; #2550 remains separate.
v6.0.6: 6 open PRs; #2432 already merged
PR / purpose Review Head / approval Reported CI Next action
#2469: Fix transaction proofs with duplicate witness ids NR 202f762cb 8/8 Target/deps
#2461: NiPoPoW: align proof construction, length-prefixed parsing, and validation NR 57d7f04c8 8/8 One of #2449 OR #2461 must deliver blacklist fix to v6.0.6 before release; not a #2432 merge prerequisite
#2535: Extract shared test fixtures and convergence observations NR; re-review efbd1e917 8/8 Own 14 support/cumulative 22; G/X owners separate; native 8/8 covers closed fork3
#2431: Respect configured CORS origins NR cb81f44ac 8/8 Target/deps
#2422: Fix v6 parameter matching call order D/NR 715ab9528 8/8 Actual v6.0.6/8995 composition retained;85 local cases. Both owning v6 core paths remain unchanged.
#2421: Remove only the transport peer on rejected handshakes API:NR; re-review 59f87747c 8/8 D/H/R/G94 retained; peer-transport correction unchanged. Independent of #2432/#2496; maintainer review remains separate from CI.
v6.0.7: 6 open PRs; #2424 current, other CI historical
PR / purpose Review Head / approval Reported CI Next action
#2424: Add wallet scan support after UTXO snapshot bootstrap NR; re-review c9c6b760c; v6.0.7 8/8 Latest merge: two version lines only; implementation/fixtures unchanged. Target diff:105 paths,+24161/-1261, cumulative prerequisites.
#2480: Harden explicit mempool dependency tracking D/NR ac0eff36c 8/8 Author preparation; Target/deps
#2479: Continue candidate assembly after limit overflow NR f75bda15c 7/8; 1 failed v6.0.7 writer assertions16/16; no #2520 API. IT12 pass/1 fail/1 ignored: DeepRollBack convergence timeout >=252; cause unproved. Maintainer: rerun failed IT only on unchanged head.
#2478: Refresh expired mining candidates on request NR b8eb8f402 8/8 Target/deps
#2429: Reject invalid first mining solutions without restart NR d04240bc7 8/8 Target/deps
#2428: Reject unknown P2P message codes as malicious NR b2e0c4690; v6.0.7 8/8 D/G/X after U/T/H retained; selected49 local. Serializer scope and v6.0.7 target unchanged.
testnet60: 1 open PR; detailed CI historical
PR / purpose Review Head / approval Reported CI Next action
#2425: Fix custom mining public key handling NR 73547149a 16/16 Target/deps

Matrix / weak-blocks: 12 open PRs; heads, CI and next actions
PR / purpose Review Head / approval Reported CI Next action
#2506: Replay processed input tips during peer sync Draft; review invited 0d7b98306 8/8 P2P reviewer: check processed-tip replay and compact-ID limits. Author: address findings and reconcile with the current composition; historical eight-case lifecycle evidence uses the combined stack.
#2505: Exercise Matrix lifecycle on three nodes and fix API dispatch Draft; review invited be808056e 8/8 Integration reviewer: after owner reviews, check the six three-node scenarios, API dispatch, fees and maturity. Current IT 52/52 passed, one unrelated ignored case; abrupt-crash recovery is not established.
#2504: Preserve Matrix transaction classification and ordering fee collection Draft; review invited 99104f519 8/8 Mining reviewer: check partitions, dependencies, fees, size limits and candidate-cache identity. CI is now green. Shared cache wake-up retains the UTXO/Digest two-fail/two-pass differential; review owners separately.
#2503: Bound pending Matrix transaction synchronization state Draft; review invited 7f648ec2e 8/8 P2P reviewer: check per-address/global accounting and release on completion, expiry, disconnect and recovery. Bounds are accounting policy, not an exact heap cap; shared fixtures are separate.
#2502: Restore Matrix fork progress and rollback state Draft; review invited 2595bc25c 7/8; 1 cancelled State/wallet reviewer: check abandoned-block propagation, wallet rollback and mempool conflict cleanup. Author/maintainer: resolve the cancelled Scala 2.11 core job; other seven jobs passed. Stall cause remains unproved.
#2501: Restore Matrix CI dependencies and mining test fixtures Draft; review invited 5fe55bb2e 8/8 Build reviewer: start with pinned bootstrap, then Scala compatibility and mining fixtures. Author: answer findings and agree which draft units to mark ready. Shared commits need one owning review.
#2500: Bind Matrix input ID responses to expected exchanges Draft; review invited 970349310 8/8 P2P reviewer: check expected-connection ID admission, retry budget and completion cleanup. Current production is unchanged by shared fixture updates; earlier broader results retain their input scope.
#2370: Ignore Matrix input block transactions for unknown blocks Non-draft; review invited 2e541b851 8/8 History/P2P reviewer: reject unknown-block body caching while retaining known retrieval, digest checks and body resend. Local 23 passed; wrong-ID negative failed as intended.
#2369: Preserve Matrix input block fork completion updates Non-draft; review invited d9ed34e06 8/8 History reviewer: preserve the current fork tree through completion updates; check its composition with #2502. Owner correction is unchanged by shared prerequisites.
#2368: Bind Matrix input block fields to extension proofs Non-draft; review invited 81f98b910 8/8 Protocol reviewer: bind declared fields to authenticated extension leaves. Preserve the real-proof positive and one-field mutation negative; separate shared synchronization/mining changes.
#2367: Bind Matrix previous transaction digest in extension fields Non-draft; review invited 4ffa7369d 8/8 Protocol reviewer: distinguish current and previous transaction digests in candidate extension fields. Owner correction remains unchanged; historical 20 XML passes plus later exit 2 are not one successful 58-test run.
#2366: Reject Matrix input-block messages from legacy peers Non-draft; review invited 657960bfa 8/8 P2P reviewer: check the source-peer protocol-version gate while preserving short-header, negative-length and transport-size rejection. Reconcile the owner commit with the current cumulative head.

Other repositories and account-wide coverage

Detailed statuses below are dated records; the 20 September account count, adjusted for #2545 closure and #2559 merge, is 114 open and 77 closed. New entries are listed without inferring uninspected review or CI results.

Closures, 13 September: #2381, covered by merged #2306; lower cap is separate policy. #2375, superseded by draft #2438; activation undecided. #2365 is covered by upstream b7e522b1; fixed 32,768 cap is separate policy. All three closed unmerged; branches/evidence retained. sigma-rust#920 merged; Rosen docs#1/Haveno#2601 remain drafts. Ecosystem merges do not select node releases.

Other Ergo-related repositories: 22 open PRs plus retained history
Repository / PR and purpose State / review Snapshot head / target Reported CI Next action
rosen-bridge/sign-protocols#2 Open Detailed status not refreshed here Not refreshed Review in its owning repository; no node prerequisite inferred.
a-shannon/ergo-sidechain-bridge#7 Open Detailed status not refreshed here Not refreshed Review in its owning repository; separate from Matrix.
rosen-bridge/docs#1 D/NR 4e9289c8b; target master 0 checks Architecture RFC; custody/signing decisions and implementation remain. No end-to-end integration claim.
haveno-dex/haveno#2601 D/NR 92255372d; target master 7/7 Separate Haveno integration; no node PR prerequisite asserted. Indexed pricing needs an external quote provider; prior simulated-transfer scenarios do not validate the final head end to end.
a-shannon/ergo#3 Closed unmerged 168bd7e16 8/8 Closed 03:20 UTC: tree 22946544 covered by #2535 efbd native 8/8; historical47/49 local and51/51 IT +1 ignored retained
a-shannon/ergo#2 NR 033992019; parent c9c6b760c 8/8 26-file composition; #2549 owns X; historical 9bbc IT 49/50/setup failure retained
a-shannon/ergo#1 NR 090a27db8; target fix/pr2466-wallet-restoration 8/8 Ready for review; retain #2409/#2466 owners and pinned increments
Ergologica#1 D/NR 79a79bfe8; target feat/persist-unconfirmed-wallet-txs-1154 0 checks; no CI triggered/running Owner CI action; #2466 follow-up; preserve #2409/#2424 joins above
a-shannon/sigmastate-interpreter#2 D/NR ed9f8db43; target fix/btc-relay-txcheck-extraction 4/4 Track review/deps
BetterMoneyLabs/basis-tracker#13 NR 333604d4a; target master 0 reported Track review/deps
BetterMoneyLabs/chaincash#20 D/NR 59ac68bb5; target master 0 reported Track review/deps
ergoplatform/eips#103 R 0772037e0; target master 0 reported Track review/deps
ergoplatform/ergo_avltree_rust#12 NR 6f7eee0c1; target main 0 reported Track review/deps
ergoplatform/ergo_avltree_rust#26 NR 1ede0fc57; target main 0 reported Track review/deps
ergoplatform/ergo-appkit#254 NR 8b12a5a03; target develop 0 reported Track review/deps
ergoplatform/ergo-node-interface#65 NR 5d6ad6f74; target master 0 reported Coordinate delivery with node #2532
ergoplatform/ergo-wallet-app#212 D/NR b835dee09; target develop 0 reported Track review/deps
ergoplatform/sigma-rust#917 NR 1196317c0; target v0.30.0 1/28; 14 failed; 12 cancelled; 1 skipped Separate NiPoPoW review effort
ergoplatform/sigmastate-interpreter#1116 D/R 580237778; target master 4/4 Track review/deps
ergoplatform/sigmastate-interpreter#1122 R a24a3032e; target master 4/4 Track review/deps
ergoplatform/sigmastate-interpreter#1184 D/R ef28b2e64; target master 3/4; 1 failed Track review/deps
mwaddip/ergo-node-rust#16 NR 614338412; target main 0 reported Separate NiPoPoW review effort
mwaddip/sigma-rust#1 NR 7d13d0d2f; target eni 0 reported Separate NiPoPoW review effort
Other projects: 5 open PRs
Repository / PR and purpose State / review Snapshot head / target Reported CI Next action
bytecodealliance/rustix#1656 NR d3dcb2db7; target main 19/51; 2 failed; 30 cancelled Track in its own repository
bytecodealliance/rustix#1657 D/NR a6534a252; target main 19/51; 2 failed; 30 cancelled Track in its own repository
bytecodealliance/rustix#1658 D/NR d67e0297a; target main 19/51; 2 failed; 30 cancelled Track in its own repository
bytecodealliance/rustix#1659 D/NR 32f42758e; target main 19/51; 2 failed; 30 cancelled Track in its own repository
sunfishcode/linux-raw-sys#191 NR c9a802c1e; target main 0 reported Track in its own repository

Historical navigation: all public PRs by A. Shannon, merged, closed without merge. Preserve merged and superseded entries when they explain a dependency; do not keep them in the active review queue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions