Conversation
a-shannon
marked this pull request as ready for review
September 7, 2026 00:02
a-shannon
force-pushed
the
fix/history-repair-results
branch
from
September 8, 2026 10:07
8ba9207 to
3885cb8
Compare
Keep synchronization scenarios with their correction in ergoplatform#2511. Reuse the spendable sorting fixture already present in ergoplatform#2480.
a-shannon
force-pushed
the
fix/history-repair-results
branch
from
September 8, 2026 10:33
3885cb8 to
974c98d
Compare
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History repair now propagates the first removal failure to startup and runtime health reporting. Required block sections are removed before their header so failed section removal leaves the information needed for retry. The continuation-height index is removed only after all its headers finish.
Startup closes the acquired history on repair failure and returns the original error before publishing it. Health reporting distinguishes repair unnecessary, completed and failed.
Review and integration
This branch starts with shared test support #2535, followed by two focused commits:
Review the storage and history changes without the shared fixtures. The narrow storage prerequisite has been extracted from #2424; this PR no longer depends on that PR's snapshot or wallet feature. The three history caller files are unchanged from the previous correction. Existing invalid-header lookup and lower store-close semantics remain outside this change.
Validation: all 38 tests in HistoryStorageRemoveSpec and HistoryRepairSpec pass together; these results are reused because the tested storage and caller files are unchanged after the rebase. Direct storage tests invoke actual HistoryStorage.remove for success and each store's failure. The previous-head run had seven of eight successful checks; integration passed 21 of 22 tests and timed out in DeepRollBackSpec, with the cause unproven. This is historical evidence; current-head CI has eight of eight successful checks. Current-head CI and integration tracker.