Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
## Changes in version 0.1.0 (in development)

### Fixes

- Fixed Windows encoding errors in `appligator` Dockerfile generation, replaced
non-ASCII characters with plain ASCII equivalents, and added `encoding="utf-8"`
to `write_text`/`read_text` calls in `gen_dockerfile.py`.

Comment on lines +3 to +8
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as there was no release with the issue yet.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!

### Enhancements

- Enhanced `appligator` with Dockerfile generation and improved Airflow integration:
Expand Down
2 changes: 1 addition & 1 deletion appligator/src/appligator/airflow/gen_dockerfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def generate(
)

dockerfile = output_dir / "Dockerfile"
dockerfile.write_text(content)
dockerfile.write_text(content, encoding="utf-8")
return dockerfile


Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Generated by appligator do not edit by hand.
# Generated by appligator - do not edit by hand.

# ── Stage 1: build ────────────────────────────────────────────
# -- Stage 1: build ---------------------------------------------------
FROM ghcr.io/prefix-dev/pixi:{{ pixi_version }}-bookworm-slim AS build

RUN apt-get update \
Expand All @@ -23,7 +23,7 @@ RUN pixi install --locked -e {{ pixi_env }}
{{ cmd }}
{% endfor %}

# ── Stage 2: runtime ──────────────────────────────────────────
# -- Stage 2: runtime -------------------------------------------------
FROM {{ base_image }}
WORKDIR {{ workdir }}

Expand Down
2 changes: 1 addition & 1 deletion appligator/tests/airflow/test_gen_dockerfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def _gen(tmp_path: Path, **kwargs) -> tuple[Path, str]:
df = generate(output_dir=out, **kwargs)
finally:
os.chdir(old)
return df, df.read_text()
return df, df.read_text(encoding="utf-8")


class TestValidation:
Expand Down
Loading