Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
forman
approved these changes
Apr 2, 2026
Collaborator
forman
left a comment
forman
left a comment
There was a problem hiding this comment.
I approve and will delete your CHANGES entry later.
Comment on lines
+3
to
+8
| ### Fixes | ||
|
|
||
| - Fixed Windows encoding errors in `appligator` Dockerfile generation, replaced | ||
| non-ASCII characters with plain ASCII equivalents, and added `encoding="utf-8"` | ||
| to `write_text`/`read_text` calls in `gen_dockerfile.py`. | ||
|
|
Collaborator
There was a problem hiding this comment.
Not needed as there was no release with the issue yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Description of PR]
Fixed Windows encoding errors in
appligatorDockerfile generation, replacednon-ASCII characters with plain ASCII equivalents, and added
encoding="utf-8"to
write_text/read_textcalls ingen_dockerfile.py.Checklist (strike out non-applicable):
CHANGES.md* [ ] Related issue exists and is referred to in the PR description andCHANGES.md* [ ] Added docstrings and API docs for any new/modified user-facing classes and functions* [ ] Changes/features documented indocs/*