Skip to content

Fix height problem with the whole page layout #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix height problem with the whole page layout #24

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
548647d
Fix height problem with the whole page layout
NullVoxPopuli Sep 28, 2025
29e739c
Update app.css
NullVoxPopuli Sep 28, 2025
32645ec
Update app.css
NullVoxPopuli Sep 28, 2025
e8483df
fix lint
mansona Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/app-styles/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
/* stylelint-disable-next-line selector-class-pattern */
.sidebar-container--full-width {
min-height: calc(100dvh - 90px);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90px is the height of the header

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however, it's 56px on narrower screens

}

@media screen and (width <= 1024px) {
/* stylelint-disable-next-line selector-class-pattern */
.sidebar-container--full-width {
min-height: calc(100dvh - 56px);
}
}

.rfc-card {
display: grid;
grid-template-columns: 100px 1fr 200px;
Expand Down