Fix height problem with the whole page layout #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-rfcs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
NullVoxPopuli
commented
Sep 28, 2025
| @@ -1,3 +1,7 @@ | |||
| .sidebar-container--full-width { | |||
| min-height: calc(100dvh - 90px); | |||
There was a problem hiding this comment.
90px is the height of the header
There was a problem hiding this comment.
however, it's 56px on narrower screens
driesdl
approved these changes
Oct 3, 2025
mansona
requested changes
Oct 3, 2025
There was a problem hiding this comment.
So I'm glad my spider senses were tingling with this and I thought to test it with the footer added #26
This is actually the wrong solution. We need the height of the whole body to have a minimum of 100vh (or whatever the right thing is)
@MinThaMie do we not already have this catered for in some of our layout stuff? 🤔
|
I did try that at first, but the background colors are then in the wrong spot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After