-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update literal paths #21
Changes from 10 commits
61f273b
eed8f1e
5acf6c9
6341cf1
0329327
6febc3a
47d5d20
e3d00f8
5ee0729
2699708
258d8d8
ec84835
03133a6
6192d25
6313ddb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import Model, { attr } from 'ember-data/model'; | ||
import { hasMany, belongsTo } from 'ember-data/relationships'; | ||
import JSONAPIAdapter from 'ember-data/adapters/json-api'; | ||
import { InvalidError, ServerError, TimeoutError, NotFoundError } from 'ember-data/adapter/error'; | ||
import Transform from '@ember-data/serializer/transform'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import Model, { attr, belongsTo, hasMany } from '@ember-data/model'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I updated this output to show the failing test. My bad, this isn't ready to go. I ran it on our project and had to manually collapse so we didn't have duplicate imports. I'll try to fix. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No worries, let me know when you need another review. |
||
import JSONAPIAdapter from '@ember-data/adapter/json-api'; | ||
import { InvalidError, ServerError, TimeoutError, NotFoundError } from '@ember-data/adapter/error'; | ||
import Transform from '@ember-data/serializer/transform'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, it seems we have a wrong import. It should be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't make the test fail, because
attr
is identified in the modules lookup.