-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update literal paths #21
Merged
dcyriller
merged 15 commits into
ember-codemods:master
from
snewcomer:sn/replace-old-paths
Jul 29, 2019
+94
−5
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
61f273b
Update literal paths
snewcomer eed8f1e
ensure replace if source is different
snewcomer 5acf6c9
add note
snewcomer 6341cf1
remove space;
snewcomer 0329327
refactor to do in registry modules loop instead of own funciton
snewcomer 6febc3a
switch order of args
snewcomer 47d5d20
fix lint
snewcomer e3d00f8
udpate successful message
snewcomer 5ee0729
actually...
snewcomer 2699708
fix
snewcomer 258d8d8
Ugly way first
snewcomer ec84835
fix lint
snewcomer 03133a6
cleanup
snewcomer 6192d25
moar cleanup
snewcomer 6313ddb
update to correct import
snewcomer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import Model from 'ember-data/model'; | ||
import attr from 'ember-data/attr'; | ||
import { hasMany, belongsTo } from 'ember-data/relationships'; | ||
import JSONAPIAdapter from 'ember-data/adapters/json-api'; | ||
import { InvalidError, ServerError, TimeoutError, NotFoundError } from 'ember-data/adapter/error'; | ||
import Transform from '@ember-data/serializer/transform'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import Model, { attr, hasMany, belongsTo } from '@ember-data/model'; | ||
import JSONAPIAdapter from '@ember-data/adapter/json-api'; | ||
import { InvalidError, ServerError, TimeoutError, NotFoundError } from '@ember-data/adapter/error'; | ||
import Transform from '@ember-data/serializer/transform'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to use the existing
registry.modules
somehow, but at this point in the codemod, they might contain old information. So in this solution, I went with iterating over the imports (post updating their source) and adding to the existing import if found.