Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-wix): inherit config types from electron-wix-msi #3858

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

erickzhao
Copy link
Member

Alternative to #3857. Inherits options from MSICreatorOptions and overrides certain properties based on how the object is constructed in code.

const creator = new MSICreator({
description: packageJSON.description,
name: appName,
version,
manufacturer: getNameFromAuthor(packageJSON.author),
exe: `${appName}.exe`,
...this.config,
appDirectory: dir,
outputDirectory: outPath,
});

  • Properties above the ...this.config spread have a default value but are configurable.
  • Properties below the ...this.config spread are hardcoded by Forge.
  • All other properties inherit from the electron-wix-msi options.

Comment on lines 14 to 16
/**
* The app's description
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about keeping the jsdoc for defined properties?
To at least document that they have a predefined default value from the maker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion: ee1e39d

@ShGKme
Copy link
Contributor

ShGKme commented Feb 19, 2025

Thanks!

@erickzhao erickzhao added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 64714a4 Feb 19, 2025
12 checks passed
@erickzhao erickzhao deleted the fix/maker-wix-msi-sync-config branch February 19, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants