Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-wix): missing option types from windows-wix-msi #3857

Closed
wants to merge 1 commit into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 17, 2025

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Sync MakerWix options type with electron-wix-msi. Some properties were missing, including windowsSign which should be used instead of deprecated options.

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ShGKme, thanks for opening this. I opened #3858 as an alternative to this PR so that we can auto-inherit any config options from the electron-wix-msi types. Let me know what you think 🙇

@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 19, 2025

@erickzhao Makes sense. I though about it, but was afraid of loosing short way to the documentation from the electronforge docs.

@ShGKme ShGKme closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants