-
Notifications
You must be signed in to change notification settings - Fork 258
[DOCS] Update Docker Compose setup #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Update Docker Compose setup #1906
Conversation
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lockewritesdocs thanks for putting this together! I did a first pass with some suggested change, let me know what you think.
Co-authored-by: Fabio Busatto <[email protected]>
@bytebilly, we can backport this change to 7.x, correct? |
We can probably update the 7.16-7.17 documentation with the same content (after testing). I cannot guarantee that this could work with any 7.x older release, and I don't think that it has great benefits to go through all of them. |
@lockewritesdocs is it possible to get the preview docs for the updated version? Thanks! |
@bytebilly, the URL for the preview link is in the main comment. I'll post it here as well: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lockewritesdocs that's awesome! I left a few final comments for you to review.
* [DOCS] Update Docker Compose setup * Update remove instructions and rename section ids * Remove cross-links, which won't display and cause errors for unreleased versions * Incorporate feedback from Fabio Co-authored-by: Fabio Busatto <[email protected]> * Clarifications and adding Docker Compose link * Remove directory name * Update container names and config file snippets * Fix typo * Incorporating final changes * Update note on exposing ports * Updating .env and docker-compose.yml files Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Fabio Busatto <[email protected]>
* [DOCS] Update Docker Compose setup * Update remove instructions and rename section ids * Remove cross-links, which won't display and cause errors for unreleased versions * Incorporate feedback from Fabio Co-authored-by: Fabio Busatto <[email protected]> * Clarifications and adding Docker Compose link * Remove directory name * Update container names and config file snippets * Fix typo * Incorporating final changes * Update note on exposing ports * Updating .env and docker-compose.yml files Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Fabio Busatto <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Fabio Busatto <[email protected]>
Updates the procedure and files for Starting the Stack with Docker Compose.
Preview link: https://stack-docs_1906.docs-preview.app.elstc.co/guide/en/elastic-stack-get-started/master/get-started-stack-docker.html#get-started-docker-tls
Closes elastic/elasticsearch#81133
Apply these changes to the Elasticsearch installation docs
After we merge this PR, we should update the section for starting a multi-node cluster with Docker Compose in the installation docs. Issue #81786 tracks this needed change.