-
Notifications
You must be signed in to change notification settings - Fork 258
Change - {version} by ${VERSION} #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adjust in config files, changing {version} by ${VERSION}
💚 CLA has been signed |
cla/check |
Thanks @rauhmaru ! I'm not a Docker compose expert so I'll leave this to @bytebilly or @lockewritesdocs to review. It looks like in #1906 this file got changed to having CRLF line endings. I'm not sure if this was intentional, but it took a bit of work to resolve the conflict of getting the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, this change doesn't work as it should be ${STACK_VERSION}
to correctly load the variable from the .env
file.
This file should be exactly the same as https://github.com/elastic/elasticsearch/tree/master/docs/reference/setup/install/docker-compose.yml
.
Is there a way to ensure that we have just one version of it? This will prevent future desync.
I went looking into how this file was used, and it seems like it's substituting AsciiDoc variables in here rather than variables from the In terms of single-sourcing the file, we don't currently depend on the |
Yes, that's the problem that I tried to fix in elastic/elasticsearch#83823, but I haven't realized that docs use a different source file. I'd suggest to start fixing the docs in this PR (by just copying the right file in this repo), and then we can iterate and see if we can have a ssot. |
This pull request is now in conflict. Could you fix it @rauhmaru? 🙏
|
This pull request does not have a backport label. Could you fix it @rauhmaru? 🙏
|
I have updated the Getting Started Guide to pull the docker-compose.yml .env files from the elasticsearch repo in #2069, so I believe this PR can be closed. Thank you for drawing attention to this discrepancy! |
Thanks for bringing this to our attention, @rauhmaru ! Even though we ended up not merging this, it prompted us to improve this documentation, and we are very grateful for that! 🙏🏻 |
Adjust in config files, changing {version} by ${VERSION}