-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiGlobalStyles]: Support adding partial global styles #7839
base: main
Are you sure you want to change the base?
[EuiGlobalStyles]: Support adding partial global styles #7839
Conversation
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
I left a comment on the originating issue for this - generally, I'm not a huge fan of adding production-impacting features for non-production use cases, and would prefer we turn off EUI's global styles in docusaurus and recreate them manually if needed. That being said, if we truly prefer this feature, I'd request that we add unit tests for each config/permutation and snapshot the CSS output. That being said, let's hold off on starting that until we determine whether we want to move forward and if we do, what granularity of customization is needed. |
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
Summary
relates to #7822
This PR updates
EuiGlobalStyles
to support conditionally enabling/disabling global base styles instead of completely disabling all added styles via<EuiProvider globalStyles={false} />
This would allow for a more flexible usage in non-Kibana specific contexts, e.g. EUI+.
The default behavior remains as is (all styles are enabled by default).
The new API allows to disable specific parts of the global styles manually, for example:
QA
General checklist
Checked in both light and dark modesChecked in mobileChecked for accessibility including keyboard-only and screenreader modes@default
if default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesUpdated visual regression testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)Updated the Figma library counterpart