-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New docs] Fix EuiProvider
's globalStyles
breaking docusaurus styles
#7822
Comments
I'm generally not a huge fan of adding functionality to production components for the sake of non-production use-cases. Can I ask why we can't just disable EUI's global styles completely via |
The idea was to be able to reuse some of the things where needed by making this more flexible. But I can agree that:
I think we could work also with |
The second bullet point is definitely my concern! I think I just also don't want to spend too much time reviewing/working on future-proof logic on source code when we don't have clear production usages in mind. Hope that makes sense! |
I think this is not needed anymore, I will close it. |
Summary
EuiProvider
's default global styles are overriding and breaking some docusaurus styles, making its typography unusable. We need to find a way how to balance these two either by fixingEuiProvider
to allow disabling some of its global styles or making docusaurus styles specificity higherAcceptance criteria
EuiProvider
is usedThe text was updated successfully, but these errors were encountered: