[EUI+] Initial typography and doc content updates #7848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
force-pushed
the
eui+/7795-content-typography-changes
branch
from
c78d6c2
to
239668d
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
tkajtoch
reviewed
Jul 2, 2024
tkajtoch
reviewed
Jul 2, 2024
| @@ -4,10 +4,10 @@ slug: /guidelines/testing | |||
| id: testing-introduction | |||
| --- | |||
|
|
|||
| <p style={{ fontSize: '22px' }}> | |||
| <div style={{ fontSize: '22px' }}> | |||
There was a problem hiding this comment.
We may need to address this since document subtitles would need to be p tags
There was a problem hiding this comment.
The output for any text is as a <p>. That's why it resulted in a p nested in another p tag.
We might want to use a separate component for applying font style changes in the mdx files instead of inline styles?
tkajtoch
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes: elastic/eui-private#113
relates to #7822
Important
Parts of this PR (anything related to the ColorModeToggle) was added as a separate PR here but kept in this PR as well for testing purposes. That previous PR for ColorModeToggle should be reviewed and merged before this one.Update: The PR was merged and this PR rebased.This PR updates the base global styles for the new EUI+ docs and additionally adds the first style updates for doc content components.
Changes:
MDXContent(wrap) and updates it to useEuiText+ custom EUI+ adjustments to ensure markdown content styling (text, lists etc)DocItem/Content(wrap) and adds custom styles for the document headingMDXComponents/AandMDXComponents/Code(wrap) and uses Eui components instead (EuiLinkandEuiCode/EuiCodeBlock)MDXComponents/Headingand uses a wrappingEuiTextto apply EUI heading stylesCallOutcomponent and uses it to wrap Docusaurus admonition components (Note, Info, Tip, Warning, Danger) and apply custom stylesFootercomponent theme to ensure static dark theme (independent from globalcolorMode)QA
gh pr checkout 7848, build the theme in/packages/docusaurus-themewithyarn buildand run the EUI+ docs page inpackages/websitewithyarn start