866 - JacksonJsonBuffer - Overriding toString

[vijaykriishna]

Ref. #866 Overriding toString function to print readable JSON pulled in from JacksonJsonBuffer.

[l-trotta]

Hey @vijaykriishna thanks for contributing! This looks good, I just have one change suggestion: in the catch, it would be better to rethrow a Runtime exception instead of returning a string. The message can stay the same, just remove the < >. Could you update the PR?

[vijaykriishna]

Hey @vijaykriishna thanks for contributing! This looks good, I just have one change suggestion: in the catch, it would be better to rethrow a Runtime exception instead of returning a string. The message can stay the same, just remove the < >. Could you update the PR?

I get your point. In my opinion, throwing RuntimeException can cause unexpected failures and this function I believe is not part of critical flow/ execution path. However, we can log this as error. Thoughts ?

[l-trotta]

@vijaykriishna okay I'm convinced, let's keep it as is! just remove the < > and then it will be ready

[vijaykriishna]

@vijaykriishna okay I'm convinced, let's keep it as is! just remove the < > and then it will be ready

Done.

[l-trotta]

thanks!