Skip to content

Commit e4049e9

Browse files
committed
866 - JacksonJsonBuffer - Overriding toString
1 parent 2f01e29 commit e4049e9

File tree

2 files changed

+87
-0
lines changed

2 files changed

+87
-0
lines changed

java-client/src/main/java/co/elastic/clients/json/jackson/JacksonJsonBuffer.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import jakarta.json.stream.JsonParser;
3131

3232
import java.io.IOException;
33+
import java.io.StringWriter;
3334
import java.lang.reflect.Type;
3435

3536
class JacksonJsonBuffer implements JsonBuffer, JsonData {
@@ -99,4 +100,19 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {
99100
}
100101
}
101102
}
103+
104+
/**
105+
* Renders this buffer as a JSON string for debugger and logging convenience.
106+
*/
107+
@Override
108+
public String toString() {
109+
StringWriter writer = new StringWriter();
110+
try (JacksonJsonpGenerator generator = new JacksonJsonpGenerator(mapper.objectMapper().createGenerator(writer))) {
111+
serialize(generator, mapper);
112+
generator.close();
113+
return writer.toString();
114+
} catch (IOException e) {
115+
return "<JacksonJsonBuffer: error rendering JSON: " + e.getMessage() + ">";
116+
}
117+
}
102118
}
Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
/*
2+
* Licensed to Elasticsearch B.V. under one or more contributor
3+
* license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright
5+
* ownership. Elasticsearch B.V. licenses this file to you under
6+
* the Apache License, Version 2.0 (the "License"); you may
7+
* not use this file except in compliance with the License.
8+
* You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
package co.elastic.clients.json.jackson;
21+
22+
import com.fasterxml.jackson.databind.ObjectMapper;
23+
import com.fasterxml.jackson.databind.util.TokenBuffer;
24+
import org.apache.commons.lang3.StringUtils;
25+
import org.junit.jupiter.api.Test;
26+
import static org.junit.jupiter.api.Assertions.assertEquals;
27+
import static org.junit.jupiter.api.Assertions.assertTrue;
28+
29+
public class JacksonJsonBufferTest {
30+
31+
private JacksonJsonpMapper mapper() {
32+
return new JacksonJsonpMapper(new ObjectMapper());
33+
}
34+
35+
@Test
36+
public void testToString_rendersJson() throws Exception {
37+
ObjectMapper om = new ObjectMapper();
38+
TokenBuffer buffer = new TokenBuffer(om, false);
39+
buffer.writeStartObject();
40+
buffer.writeStringField("foo", "bar");
41+
buffer.writeNumberField("baz", 42);
42+
buffer.writeEndObject();
43+
44+
JacksonJsonBuffer jsonBuffer = new JacksonJsonBuffer(buffer, mapper());
45+
String json = jsonBuffer.toString();
46+
assertTrue(json.contains("\"foo\":\"bar\""));
47+
assertTrue(json.contains("\"baz\":42"));
48+
assertTrue(json.startsWith("{") && json.endsWith("}"));
49+
}
50+
51+
@Test
52+
public void testToString_emptyBuffer() throws Exception {
53+
ObjectMapper om = new ObjectMapper();
54+
TokenBuffer buffer = new TokenBuffer(om, false);
55+
JacksonJsonBuffer jsonBuffer = new JacksonJsonBuffer(buffer, mapper());
56+
String json = jsonBuffer.toString();
57+
assertEquals(StringUtils.EMPTY, json.trim());
58+
}
59+
60+
@Test
61+
public void testToString_invalidBuffer() throws Exception {
62+
ObjectMapper om = new ObjectMapper();
63+
TokenBuffer buffer = new TokenBuffer(om, false);
64+
// Write some invalid JSON (start object but don't close)
65+
buffer.writeStartObject();
66+
JacksonJsonBuffer jsonBuffer = new JacksonJsonBuffer(buffer, mapper());
67+
String json = jsonBuffer.toString();
68+
// Should not throw, but may contain error or partial output
69+
assertTrue(json.startsWith("{"));
70+
}
71+
}

0 commit comments

Comments
 (0)