New FontData Constructor to create a deep copy #2128
Merged
+121
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 545 files 545 suites 29m 32s ⏱️ Results for commit 3b174ca. ♻️ This comment has been updated with latest results. |
ShahzaibIbrahim
force-pushed
the
master-296
branch
from
0441bce to
d32fe1c
Compare
ShahzaibIbrahim
force-pushed
the
master-296
branch
2 times, most recently
from
c7a5291 to
46cfcee
Compare
HeikoKlare
requested changes
May 30, 2025
There was a problem hiding this comment.
Having a proper copy constructor for FontData sounds reasonable to me.
However, the implementations are no proper copy constructors. They seem to be copies of the String-based constructors which is only able to copy the data present in the string, while a proper copy constructor can simply deep-copy all the data from the existing FontData object.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/FontData.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/FontData.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/graphics/FontData.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/graphics/FontData.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/graphics/FontData.java
Outdated
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-296
branch
from
14a9e9c to
6174057
Compare
HeikoKlare
reviewed
Jun 4, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/FontData.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/FontData.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/FontData.java
Outdated
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-296
branch
2 times, most recently
from
2d5c93f to
aee6314
Compare
HeikoKlare
approved these changes
Jun 5, 2025
ShahzaibIbrahim
force-pushed
the
master-296
branch
from
e337898 to
3a3deb9
Compare
|
@ShahzaibIbrahim can you please bump the appropriate versions and link/document the failing tests? |
[win32] Introducing new FontData Constructor to create a deep copy This change will give us a chance to use proper channel to create a deep copy of FontData object instead of using FontData(fd.toString)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will give us a chance to use proper channel to create a deep copy of FontData object instead of using FontData(fd.toString)