Skip to content

New FontData Constructor to create a deep copy #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ShahzaibIbrahim
Copy link
Contributor

This change will give us a chance to use proper channel to create a deep copy of FontData object instead of using FontData(fd.toString)

Copy link
Contributor

github-actions bot commented May 8, 2025

Test Results

   539 files   -  6     539 suites   - 6   39m 48s ⏱️ + 4m 14s
 4 341 tests  - 36   4 325 ✅  - 34   15 💤  - 3  1 ❌ +1 
16 614 runs   - 33  16 475 ✅  - 31  138 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 46cfcee. ± Comparison against base commit 63048a2.

This pull request removes 37 and adds 1 tests. Note that renamed tests count towards both.
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_FontData ‑ test_ConstructorLjava_lang_FontData

♻️ This comment has been updated with latest results.

This change will give us a chance to use proper channel to create a deep
copy of FontData object instead of using FontData(fd.toString)
Using the new constructor FontData(fontData) to deep copy the object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve FontData Copying: Replace String Constructor with Safer Approach
1 participant