Cache all Fonts in ScalingSWTFontRegistry on creation #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
reviewed
Jun 16, 2025
There was a problem hiding this comment.
Overall, the change looks fine to me. The FontData copy can now be improved with the just added copy constructor.
Still I would like to have @akoch-yatta have another at look at this change as it affects quite central, crucial code.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ScalingSWTFontRegistry.java
Outdated
Show resolved
Hide resolved
arunjose696
force-pushed
the
arunjose696/cacheFontData
branch
from
10cbd46 to
83723da
Compare
Previously, system fonts were not cached during their creation in ScalingSWTFontRegistry. This change ensures that system fonts, are now cached in fontsKeyMap
HeikoKlare
force-pushed
the
arunjose696/cacheFontData
branch
from
83723da to
0b25f46
Compare
HeikoKlare
approved these changes
Jun 17, 2025
|
Taking another look, I understood again that this is really only about adding the system font to the cache based on font data. Thus I merge this to proceed with the work based on top of it. Still would be nice if you can double-check once you are back, @akoch-yatta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, system fonts were not cached during their creation in ScalingSWTFontRegistry. This change ensures that system fonts, are now cached in fontsKeyMap