Add usage analytics filter panel component - #30120
Open
avervaet wants to merge 11 commits into
Open
Conversation
Contributor
Author
|
This change is part of the following stack:
Change managed by git-spice. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
![dust-agent[bot]](https://avatars.githubusercontent.com/in/1117438?s=60&v=4){kind=small}
avervaet
changed the base branch from
avervaet/usage-analytics-member-group-filter-api
to
sf/analytics-consumption-attribution-scope-ts
August 6, 2026 14:39
avervaet
force-pushed
the
avervaet/usage-analytics-filtering-react-component
branch
from
August 6, 2026 14:39
98ba4e3 to
569c5d9
Compare
sfriquet
force-pushed
the
sf/analytics-consumption-attribution-scope-ts
branch
from
August 6, 2026 17:12
c4e8e78 to
085a959
Compare
avervaet
force-pushed
the
avervaet/usage-analytics-filtering-react-component
branch
from
August 7, 2026 07:45
27af54d to
9803e7c
Compare
sfriquet
force-pushed
the
sf/analytics-consumption-attribution-scope-ts
branch
from
August 7, 2026 07:55
085a959 to
4fc055b
Compare
avervaet
force-pushed
the
avervaet/usage-analytics-filtering-react-component
branch
from
August 7, 2026 07:56
9803e7c to
fc24f8b
Compare
avervaet
changed the base branch from
sf/analytics-consumption-attribution-scope-ts
to
avervaet/consumption-scope-query-auth-fix
August 7, 2026 08:35
avervaet
force-pushed
the
avervaet/usage-analytics-filtering-react-component
branch
from
August 7, 2026 08:35
fc24f8b to
17731bc
Compare
avervaet
commented
Aug 7, 2026
Contributor
Author
There was a problem hiding this comment.
This file will obviously be discarded later on
This was referenced Aug 7, 2026
Open
avervaet
commented
Aug 7, 2026
avervaet
commented
Aug 7, 2026
| import { | ||
| USAGE_FILTER_MOCK_ENTITIES, | ||
| USAGE_FILTER_MOCK_GROUPS, | ||
| } from "@app/components/workspace/analytics/usageFilterMockData"; |
Contributor
Author
There was a problem hiding this comment.
removed higher in the stack
This was referenced Aug 7, 2026
Introduces a filtering React component for usage analytics with mock data and a preview page/route to iterate on the UI in isolation.
Wires UsageFilterPanel into AnalyticsConsumptionPage above the consumption chart instead of its temporary mock preview page, and removes the now-dangling preview route. Restyles the trigger to match the panel's own Cancel/Apply button formatting and right-aligns the popover with the chart.
Addresses GEN6 review comment: branching on the UsageFilterCategory union with if/else doesn't get compile-time exhaustiveness checking.
Addresses react-doctor's no-giant-component warning. Extracts the category nav, per-category controls (member groups, model complexity, agent scopes), entity checkbox list, selection summary, footer, and entity icon renderer into usageFilterPanel/, keeping the JSX split pure presentational and leaving all state/handlers in the parent.
avervaet
force-pushed
the
avervaet/consumption-scope-query-auth-fix
branch
from
August 7, 2026 10:10
6260659 to
3bae94d
Compare
avervaet
force-pushed
the
avervaet/usage-analytics-filtering-react-component
branch
from
August 7, 2026 10:10
17731bc to
a72fed4
Compare
Member group selection, model complexity dropdown state, and selection-summary collapse state only matter to their own sub-component, so own them there instead of threading props down from the parent.
aubin-tchoi
approved these changes
Aug 7, 2026
aubin-tchoi
left a comment
aubin-tchoi
left a comment
Contributor
There was a problem hiding this comment.
LGTM
as per IRL could have been split in a PR that describes the layout with maybe only 1 kind of filter and separate PRs to add each filter. these ones could have directly contained the data wiring (IMHO the mocks make it a big longer to review as we know that part of the code will change)
| private: "Private", | ||
| }; | ||
|
|
||
| export const USAGE_MODEL_TIERS = ["fast", "standard", "complex"] as const; |
Contributor
There was a problem hiding this comment.
this probably already exists somewhere else (for the input bar)
Contributor
Author
There was a problem hiding this comment.
Will be harmonized in the pr wiring real data to the model panel
avervaet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a filtering React component for usage analytics chart with mock
data and a preview page/route to iterate on the UI in isolation.
Risk
Low - Purely additive not logic tight to it yet, safe to rollback
Deploy Plan