Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length limit (maximum number of words) in generation #1378

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

g-prz
Copy link
Contributor

@g-prz g-prz commented Jan 15, 2025

This PR aims at proposing a limit of words that are generated, similarly to a max number of tokens (#88).

@g-prz g-prz force-pushed the add-max-words-limitation branch from 238910d to cb65326 Compare January 15, 2025 19:20
@g-prz g-prz changed the title Add maximum number of words limit in generation Add length limit (maximum number of words) in generation Jan 15, 2025
@g-prz g-prz force-pushed the add-max-words-limitation branch from c41db95 to e2e7318 Compare January 16, 2025 15:25
@g-prz
Copy link
Contributor Author

g-prz commented Jan 16, 2025

@rlouf seems ready for review

@g-prz g-prz force-pushed the add-max-words-limitation branch from dca604c to 0aa219d Compare January 27, 2025 15:40
@g-prz
Copy link
Contributor Author

g-prz commented Jan 27, 2025

@rlouf WDYT?

@yvan-sraka yvan-sraka requested a review from rlouf January 28, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant