Skip to content

Fix comparison-with-wider-type CodeQL issue #129742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvorli merged 2 commits into from
Jun 24, 2026
Merged

Fix comparison-with-wider-type CodeQL issue #129742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55ff856
Fix comparison-with-wider-type CodeQL issue
janvorli Jun 23, 2026
9240721
Copilot feedback
janvorli Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/coreclr/gc/gcinternal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,10 +1325,10 @@ class heap_select
uint16_t proc_no[MAX_SUPPORTED_HEAPS];
uint16_t node_no[MAX_SUPPORTED_HEAPS];
uint16_t max_node_no = 0;
uint16_t heap_num;
int heap_num;
for (heap_num = 0; heap_num < n_heaps; heap_num++)
{
if (!GCToOSInterface::GetProcessorForHeap (heap_num, &proc_no[heap_num], &node_no[heap_num]))
if (!GCToOSInterface::GetProcessorForHeap (static_cast<uint16_t>(heap_num), &proc_no[heap_num], &node_no[heap_num]))
break;
assert(proc_no[heap_num] < GCToOSInterface::GetMaxProcessorCount());
if (!do_numa || node_no[heap_num] == NUMA_NODE_UNDEFINED)
Expand Down
Loading