Fix comparison-with-wider-type CodeQL issue#129742
Merged
Merged
Conversation
CodeQL has complained about a loop with heap_num variable of 16 bit type and n_heaps of 32 bit type.
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GC heap_select::init heap enumeration loop to avoid mixed-width comparisons flagged by CodeQL, while preserving existing heap-to-processor/NUMA discovery behavior.
Changes:
- Change
heap_numloop variable fromuint16_ttointwhen iterating up ton_heaps. - Add an explicit cast when passing
heap_numtoGCToOSInterface::GetProcessorForHeap(...)(which takes auint16_t).
kkokosa
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL has complained about a loop with heap_num variable of 16 bit type and n_heaps of 32 bit type.