Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Trac query styling to be more compact and support mobile. #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sarahboyce
Copy link
Contributor

@sarahboyce sarahboyce commented Jun 24, 2023

image

Changes:

  • updated the default queries to add the description search to be available by default (as if a permanent search bar)
  • reduced the columns in the default view (also nicer for mobile, ignore the image here, I do not have all columns available locally)
  • reduced general use of margin
  • the paging option at the top of the table is now hidden
  • the options for grouping, showing the description under each desult, changing the page side is hidden for guests - this is to make the page less noisy on first visit

No worries if it's not the right way to go with it, just thought I would have a play 👍 got me set up with the project

Also added mobile support
image

@sarahboyce sarahboyce changed the title Updated track query styling to be more compact. Updated Trac query styling to be more compact and support mobile. Jun 25, 2023
@keikoro
Copy link

keikoro commented Sep 20, 2024

I've been looking for a way to add the description search field by default, would be great to at least have that added.

@carltongibson
Copy link
Member

Oooh… this looks fun @sarahboyce 🤩

I could particularly do with this for the Timeline view

Copy link

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a clear improvement over the status quo.

@sarahboyce sarahboyce added the styling Issues that deal with styling label Oct 5, 2024
@sarahboyce sarahboyce requested a review from bmispelon October 5, 2024 08:17
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thanks for picking it up! 🚀

I think there's a few easy wins that we could already merge, but the CSS changes would require a more thorough review (we need to consider other pages that use the stylesheet, not just the ticket list).

Do you have the bandwidth to split things out into separate commits, or would you prefer if I did it?

@@ -259,6 +279,10 @@ div[role="main"]{
}
}

#ctxtnav {
display: none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the effect of this change? From my (limited) testing, the ctctnav element is not present on the ticket list (I've seen it only on wiki pages)

trac-env/conf/trac.ini Show resolved Hide resolved
@@ -76,6 +76,11 @@ <h1>Issues</h1>
</div>
</div>


# if req.authname == 'anonymous' or req.authname == '':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use if not req.is_authenticated I think

@@ -76,6 +76,11 @@ <h1>Issues</h1>
</div>
</div>


# if req.authname == 'anonymous' or req.authname == '':
<div id="guest"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the advantage of using this empty element rather than for example a class on the <body>?

trac-env/templates/site_head.html Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
styling Issues that deal with styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants