Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styling] Too much whitespace between mainnav and content #152

Closed
smithdc1 opened this issue Jan 24, 2024 · 4 comments
Closed

[styling] Too much whitespace between mainnav and content #152

smithdc1 opened this issue Jan 24, 2024 · 4 comments
Assignees
Labels
styling Issues that deal with styling

Comments

@smithdc1
Copy link
Member

For me, there is too much white space between the navbar and the content. It's somewhat noticeable on desktop, but is much more noticeable on narrower screen widths. For example:

image

@bmispelon bmispelon added the styling Issues that deal with styling label Jan 24, 2024
@sarahboyce
Copy link
Contributor

I agree 😁 I think I tried to do this quite a while ago: #142

@bmispelon
Copy link
Member

I agree 😁 I think I tried to do this quite a while ago: #142

Your PR does a lot more than just fix this whitespace issue though (and I will get to reviewing it at some point, I promise 😁 ).

I wonder if an easy fix/win here would be to hide/remove the empty <div id="ctxtnav"> that's in the top of all pages (and seems to only have visible elements on wiki pages), what do you think?

@sarahboyce
Copy link
Contributor

sarahboyce commented Jan 25, 2024

I wonder if an easy fix/win here would be to hide/remove the empty <div id="ctxtnav"> that's in the top of all pages

Yeah that's a good idea 👍

@bmispelon bmispelon self-assigned this Jan 26, 2024
bmispelon added a commit to bmispelon/code.djangoproject.com that referenced this issue Jan 26, 2024
felixxm pushed a commit that referenced this issue Jan 26, 2024
@felixxm
Copy link
Member

felixxm commented Jan 26, 2024

Fixed.

@felixxm felixxm closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
styling Issues that deal with styling
Projects
None yet
Development

No branches or pull requests

4 participants