Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to traverse a bvh passing a context from parent to children #191

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

Makogan
Copy link
Contributor

@Makogan Makogan commented Apr 23, 2024

No description provided.

@sebcrozet sebcrozet self-requested a review April 24, 2024 08:03
Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

Please update the CHANGELOG (under an #unreleased section) to mention these additions.

src/partitioning/visitor.rs Outdated Show resolved Hide resolved
src/partitioning/visitor.rs Outdated Show resolved Hide resolved
src/partitioning/visitor.rs Outdated Show resolved Hide resolved
src/partitioning/qbvh/traversal.rs Outdated Show resolved Hide resolved
src/partitioning/qbvh/traversal.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Makogan and others added 5 commits April 24, 2024 12:44
Co-authored-by: Sébastien Crozet <[email protected]>
Removed because `SimdVisitor`'s default implementation causes issues.
It will be automatically implemented for types that may want to implement
`SimdVisitorWithContext` and thus cause them to automatically implement
the default trait implementation. Since there can only be one
trait implementation per type, this effectively prevents the use
of the new trait.
@sebcrozet sebcrozet merged commit 2ac354a into dimforge:master Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants