Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Partial Serialization support + Missing Default & Debug derives #184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AnneKitsune
Copy link

@AnneKitsune AnneKitsune commented Feb 16, 2019

Allows using serde to serialize rigidbodies among other things.

@AnneKitsune AnneKitsune changed the title Added Partial Serialization support Added Partial Serialization support + Missing Default & Debug derives Feb 16, 2019
@L-as
Copy link

L-as commented Apr 17, 2019

I updated this to work with the latest version of nphysics: https://github.com/Laaas/nphysics

@sebcrozet
Copy link
Member

@laaas Thank you for updating this! Would you mind porting your changes in this PR, or perhaps open a new one?

Also, could you please double-check that the serde-serialize feature of nalgebra is really not enabled if ncollide's serde feature isn't enabled either. If I remember correctly there is some kind of Cargo bug that unifies all the features independently from the target.cfg statements. One way of checking this is to compile (in verbose mode) ncollide without the serde feature and see if the command line compiling nalgebra includes the serde-serialize feature or not.

@L-as
Copy link

L-as commented Apr 17, 2019

You are unfortunately right.

@sebcrozet
Copy link
Member

@laaas Thank you for checking. I guess one way of working around this is to add a feature serde-serialize = [ "serde", "nalgebra/serde-serialize" ] to ncollide instead of all those target.cfg.

@L-as
Copy link

L-as commented Apr 18, 2019

@sebcrozet what should I do with this PR then?

@AnneKitsune
Copy link
Author

You can make a pull request over my fork and it will update this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants