Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,27 @@ def node_output_info() -> NodeOutputInfo:


@pytest.fixture
def node_requirements_info_data() -> dict:
def node_requirements_info_data(
node_requirements_info_min_data: dict[str, int],
) -> dict[str, bool | int]:
"""
Some data to define a NodeRequirementsInfo object.
"""

return {"cpu": 256, "gpu": True, "memory": 512, "timeout": 60}
return {
"cpu": 256,
"gpu": True,
"memory": 512,
**node_requirements_info_min_data,
}


@pytest.fixture
def node_requirements_info_min_data() -> dict[str, int]:
"""Minimum data to build a `NodeRequirementsInfo` instance."""
return {
"timeout": 60,
}


@pytest.fixture
Expand Down
23 changes: 22 additions & 1 deletion tests/test_node_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,28 @@ def test_node_requirements_info(node_requirements_info_data: dict):
assert node_requirements_info.model_dump() == node_requirements_info_data


@pytest.mark.parametrize("field", ["cpu", "gpu", "memory", "timeout"])
def test_node_requirements_info_min(
node_requirements_info_min_data: dict[str, Any],
) -> None:
"""
Asserts that `NodeRequirementsInfo` can be instantiated without
optional values.
"""
instance = NodeRequirementsInfo(**node_requirements_info_min_data)
assert instance.model_dump() == {
"cpu": None,
"gpu": None,
"memory": None,
**node_requirements_info_min_data,
}


@pytest.mark.parametrize(
"field",
[
"timeout",
],
)
def test_node_requirements_info_raise_missing(
node_requirements_info_data: dict, field: str
):
Expand Down
6 changes: 3 additions & 3 deletions uncertainty_engine_types/node_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ class NodeOutputInfo(BaseModel):


class NodeRequirementsInfo(BaseModel):
cpu: int
gpu: bool
memory: int
cpu: int | None = None
gpu: bool | None = None
memory: int | None = None
timeout: int


Expand Down
Loading