Skip to content

PB-318: Make NodeRequirementsInfo.cpu | gpu | memory optional#74

Merged
cariad merged 1 commit intomainfrom
PB-318-cariad-make-cpu-ram-and-gpu-optional-in-node-info
Feb 2, 2026
Merged

PB-318: Make NodeRequirementsInfo.cpu | gpu | memory optional#74
cariad merged 1 commit intomainfrom
PB-318-cariad-make-cpu-ram-and-gpu-optional-in-node-info

Conversation

@cariad
Copy link
Contributor

@cariad cariad commented Feb 2, 2026

Nodes currently provide NodeRequirementsInfo.cpu, NodeRequirementsInfo.gpu and NodeRequirementsInfo.memory values to satisfy the legacy deployment.

In preparation for the legacy deployment being retired, this change makes those properties optional.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the cpu, gpu, and memory fields optional in the NodeRequirementsInfo class in preparation for retiring the legacy deployment that currently requires these fields. Only the timeout field remains required.

Changes:

  • Modified NodeRequirementsInfo to make cpu, gpu, and memory fields optional with None defaults
  • Updated test parametrization to reflect only timeout as a required field
  • Added new test test_node_requirements_info_min to verify instantiation with minimal (required-only) data
  • Refactored test fixtures to support both minimal and full NodeRequirementsInfo configurations

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
uncertainty_engine_types/node_info.py Made cpu, gpu, and memory fields optional with None defaults in NodeRequirementsInfo
tests/test_node_info.py Updated parametrize list to only include timeout as required field and added test for minimal instantiation
tests/conftest.py Refactored fixtures to include node_requirements_info_min_data and updated node_requirements_info_data to build on it

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cariad cariad marked this pull request as ready for review February 2, 2026 16:51
@cariad cariad merged commit ba279b6 into main Feb 2, 2026
11 checks passed
@cariad cariad deleted the PB-318-cariad-make-cpu-ram-and-gpu-optional-in-node-info branch February 2, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments