Conversation
…e incrementally removed from nodes
There was a problem hiding this comment.
Pull request overview
This PR makes the cpu, gpu, and memory fields optional in the NodeRequirementsInfo class in preparation for retiring the legacy deployment that currently requires these fields. Only the timeout field remains required.
Changes:
- Modified
NodeRequirementsInfoto makecpu,gpu, andmemoryfields optional withNonedefaults - Updated test parametrization to reflect only
timeoutas a required field - Added new test
test_node_requirements_info_minto verify instantiation with minimal (required-only) data - Refactored test fixtures to support both minimal and full
NodeRequirementsInfoconfigurations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uncertainty_engine_types/node_info.py | Made cpu, gpu, and memory fields optional with None defaults in NodeRequirementsInfo |
| tests/test_node_info.py | Updated parametrize list to only include timeout as required field and added test for minimal instantiation |
| tests/conftest.py | Refactored fixtures to include node_requirements_info_min_data and updated node_requirements_info_data to build on it |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cjfuller-dev
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes currently provide
NodeRequirementsInfo.cpu,NodeRequirementsInfo.gpuandNodeRequirementsInfo.memoryvalues to satisfy the legacy deployment.In preparation for the legacy deployment being retired, this change makes those properties optional.