Skip to content

Conversation

@alisnwu
Copy link

@alisnwu alisnwu commented Oct 25, 2024

closes #130

@alisnwu
Copy link
Author

alisnwu commented Oct 25, 2024

@sbillinge ready for review

@bobleesj
Copy link
Contributor

@alisnwu we might need to wait for this PR to be merged since we have v3.4.3 awaiting to be released first.

you could close this PR for now and re-open after #134 is closed

@alisnwu alisnwu closed this Oct 25, 2024
@alisnwu alisnwu reopened this Oct 26, 2024
@bobleesj
Copy link
Contributor

Lets re open after testing the full release version

@alisnwu alisnwu closed this Oct 26, 2024
@sbillinge
Copy link
Contributor

3.4.3 merged so I am reopening this and I can merge it, it looks fine. But there are some more issues to merge before we push this out.

@sbillinge sbillinge reopened this Oct 26, 2024
@sbillinge sbillinge merged commit 9f8269c into diffpy:main Oct 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update requires-python in pyproject.toml

3 participants