Introduce sva_sequence_repetition_exprt
#1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
sva_sequence_repetition_exprt
branch
4 times, most recently
from
9996699 to
cda5cc0
Compare
tautschnig
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Requires conflict resolution now that #1082 has been merged.
|
|
||
| expr.op1() = from_integer(n, integer_typet{}); | ||
|
|
||
| expr.type() = verilog_sva_sequence_typet{}; |
There was a problem hiding this comment.
Is this even necessary anymore?
There was a problem hiding this comment.
Unfortunately yes, since the parser doesn't use the expression constructors.
This introduces sva_sequence_repetition_exprt as a base class for the SVA repetition operators [*...], [=...], [->...].
kroening
force-pushed
the
sva_sequence_repetition_exprt
branch
from
cda5cc0 to
649411d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
sva_sequence_repetition_exprtas a base class for the SVA repetition operators[*...],[=...],[->...].