SystemVerilog: const
#1063
Merged
SystemVerilog: const
#1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check that the LHS of assignments is not const.
tautschnig
approved these changes
Apr 15, 2025
| @@ -94,6 +94,7 @@ IREP_ID_ONE(sva_implies) | |||
| IREP_ID_ONE(sva_not) | |||
| IREP_ID_ONE(sva_or) | |||
| IREP_ID_ONE(module_instance) | |||
| IREP_ID_TWO(C_const, #const) | |||
There was a problem hiding this comment.
Shouldn't we just use C_constant from CBMC? Over there, it's used for exactly the same purpose.
There was a problem hiding this comment.
Yes, but it's mis-named. There is nothing constant about const variables.
Ideally, I'd like to rename #constant into #c_const.
There was a problem hiding this comment.
I agree with the mis-naming. I obviously don't intend to block this PR, but I'd prefer to see a medium-term cleanup of this across the two code bases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check that the LHS of assignments is not
const.