fix: [DHIS2-18459] Re-use obtained maxTeLimit (2.41) #19590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muilpp
approved these changes
Jan 3, 2025
|
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing another fix #19240 (which does fix the nullPointer issue, but does not consider a small functional gap)
The mentioned PR does not consider if the maxTeLimit is obtained from TrackedEntityType. And proceeds to fetch it from Program again. (Ignores the maxTeLimit could also have been obtained from the TET)
Since the obtained maxTeLimit is injected into the Params, it makes sense to simply re-use that. There already exists a unit test case to check the NPE from the previous PR.