fix: [DHIS2-18459] Re-use obtained maxTeLimit (2.41) (#19590)

* fix: [DHIS2-18459] Re-use obtained maxTeLimit (2.41) * Apply spotless * Add hasMaxTeLimit convenience method * Remove this to make it consistent
dhis2 · Jan 3, 2025 · 2fb6a08 · 2fb6a08
1 parent ce07f13
commit 2fb6a08
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/dhis-2/dhis-api/src/main/java/org/hisp/dhis/trackedentity/TrackedEntityQueryParams.java b/dhis-2/dhis-api/src/main/java/org/hisp/dhis/trackedentity/TrackedEntityQueryParams.java
@@ -469,6 +469,11 @@ public boolean hasTrackedEntityType() {
     return trackedEntityType != null;
   }
 
+  /** Indicates whether this parameters specifies a max TE limit. */
+  public boolean hasMaxTeLimit() {
+    return maxTeLimit > 0;
+  }
+
   /** Indicates whether this parameters is of the given organisation unit mode. */
   public boolean isOrganisationUnitMode(OrganisationUnitSelectionMode mode) {
     return orgUnitMode != null && orgUnitMode.equals(mode);

diff --git a/...s-service-core/src/main/java/org/hisp/dhis/trackedentity/DefaultTrackedEntityService.java b/...s-service-core/src/main/java/org/hisp/dhis/trackedentity/DefaultTrackedEntityService.java
@@ -679,16 +679,16 @@ public void validateSearchScope(TrackedEntityQueryParams params, boolean isGridS
         }
       }
 
-      checkIfMaxTeiLimitIsReached(params, maxTeiLimit);
       params.setMaxTeLimit(maxTeiLimit);
+      checkIfMaxTeiLimitIsReached(params);
     }
   }
 
-  private void checkIfMaxTeiLimitIsReached(TrackedEntityQueryParams params, int maxTeiLimit) {
-    if (maxTeiLimit > 0) {
+  private void checkIfMaxTeiLimitIsReached(TrackedEntityQueryParams params) {
+    if (params.hasMaxTeLimit()) {
       int teCount = trackedEntityStore.getTrackedEntityCountForGridWithMaxTeiLimit(params);
 
-      if (teCount > maxTeiLimit) {
+      if (teCount > params.getMaxTeLimit()) {
         throw new IllegalQueryException("maxteicountreached");
       }
     }

diff --git a/...core/src/main/java/org/hisp/dhis/trackedentity/hibernate/HibernateTrackedEntityStore.java b/...core/src/main/java/org/hisp/dhis/trackedentity/hibernate/HibernateTrackedEntityStore.java
@@ -407,19 +407,14 @@ private String getCountQuery(TrackedEntityQueryParams params) {
    * @return a count SQL query
    */
   private String getCountQueryWithMaxTeiLimit(TrackedEntityQueryParams params) {
-    boolean hasMaxTeiCountToReturn =
-        params.hasProgram() && params.getProgram().hasMaxTeiCountToReturn();
     return new StringBuilder()
         .append(getQueryCountSelect(params))
         .append(getQuerySelect(params))
         .append("FROM ")
         .append(getFromSubQuery(params, true, true))
         .append(getQueryRelatedTables(params))
         .append(getQueryGroupBy(params))
-        .append(
-            hasMaxTeiCountToReturn
-                ? getLimitClause(params.getProgram().getMaxTeiCountToReturn() + 1)
-                : "")
+        .append(params.hasMaxTeLimit() ? getLimitClause(params.getMaxTeLimit() + 1) : "")
         .append(" ) tecount")
         .toString();
   }