-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): fix hide zeros filter #4200
Open
BonomoAlessandro
wants to merge
29
commits into
main
Choose a base branch
from
fix(frontend)/fix-hide-zeros-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
4bc4e35
fixes token filter
BonomoAlessandro 77f19ae
restructures code
BonomoAlessandro cfd98f6
simplifies filter logic
BonomoAlessandro 1567896
reformat code
BonomoAlessandro a8cd382
resolves lint issue
BonomoAlessandro 2d6c680
resolves lint issue
BonomoAlessandro 4994511
resolves lint issue
BonomoAlessandro 9d3d370
resolves lint issue
BonomoAlessandro 9cfe7c8
resolves lint issue
BonomoAlessandro b9c687f
resolves lint issue
BonomoAlessandro 1a64616
🤖 Apply formatting changes
github-actions[bot] d6a3c86
🤖 Apply formatting changes
github-actions[bot] 30c392d
Merge branch 'main' into fix(frontend)/fix-hide-zeros-filter
BonomoAlessandro 04027b6
resolves lint issue
BonomoAlessandro cac86a4
resolves lint issue
BonomoAlessandro 9e53308
🤖 Apply formatting changes
github-actions[bot] 25f97c3
Merge branch 'main' into fix(frontend)/fix-hide-zeros-filter
BonomoAlessandro e35e8c1
Merge branch 'main' into fix(frontend)/fix-hide-zeros-filter
BonomoAlessandro 8dad9b5
Merge branch 'main' into fix(frontend)/fix-hide-zeros-filter
BonomoAlessandro 40b9d93
resolves lint issue
BonomoAlessandro 91af2e4
Merge branch 'main' into fix(frontend)/fix-hide-zeros-filter
BonomoAlessandro 6bc3966
moves filter logic into token-group.utils.ts
BonomoAlessandro ddebe0a
implements some filterTokenGroups tests
BonomoAlessandro 38e58da
🤖 Apply formatting changes
github-actions[bot] 3038981
reformat comments
BonomoAlessandro 1394434
resolves lint issues
BonomoAlessandro 239bf34
resolves lint issues
BonomoAlessandro 3a23005
resolves lint issues
BonomoAlessandro 97737bf
Merge branch 'main' into fix(frontend)/fix-hide-zeros-filter
BonomoAlessandro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the above be put in an util, using
reduce
with a few tests please?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntonioVentilii i can put the code into an util and write some tests, but why should i use
reduce
instead offilter
? Filtering is exactly what i want to do in this case