fix(frontend): fix hide zeros filter #4200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ]; | ||
|
|
||
| return checks.some((check) => check()); | ||
| }; |
There was a problem hiding this comment.
can we not use the Number(balance ?? 0n) || (usdBalance ?? 0) || $showZeroBalances logic? Will it not work?
There was a problem hiding this comment.
@AntonioVentilii you are right. This is much better
|
|
||
| sortedTokensOrGroups = groupedTokens.filter((t: TokenUiOrGroupUi) => | ||
| isTokenUiGroup(t) ? t.tokens.some((tok: TokenUi) => hasBalance(tok)) : hasBalance(t) | ||
| ); |
There was a problem hiding this comment.
can the above be put in an util, using reduce with a few tests please?
There was a problem hiding this comment.
@AntonioVentilii i can put the code into an util and write some tests, but why should i use reduce instead of filter? Filtering is exactly what i want to do in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If a user who is not invested in ck tokens activates the
Hide zerosoption, these tokens disappear. But the user should always know, that there is an option to invest in cks. This means if there is a token group and at least one of the tokens do have a balance, display the whole group.Changes
Tests
before:
after:
