Follow-up of moc.js API update (Serokell) #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: In the compiler, we changed the `parseMotokoTyped` function for the LSP that allows caching for better performance. This needs to be exposed by node-motoko. Moreover, `parseMotokoWithDeps` was added which parses the file and returns immediate dependencies. Solution: Regenerate based on a local compiler build. Change `file.ts` and `index.ts` to account for these functions.
Problem: We should test our changes related to caching, to ensure everything is working as intended. Solution: Write a couple of tests related to checking caches for changed and unchanged files.
GoPavel
changed the title
This was referenced Mar 4, 2025
|
Thank you for the PR! I'm thinking that we get dfinity/motoko#4931 merged first and then revisit this once we release the caching logic. |
Problem: We need to pass the filename to the import resolver, which requires passing the filename to `parseMotokoWithDeps`. Solution: Regenerate compiler and use the updated compiler API. Add some tests to be sure it's working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update IDE API of the
moccompiler for the: dfinity/motoko#4931