LSP: Implement a cache for typechecking (Serokell, Milestone-1) #4931
+205
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When the language server loads a file, it goes through the process of typechecking all of its dependencies. We can be smarter about it and only load typecheck files that were invalidated. Solution: Add `lsp_load_progs` that uses a cache to avoid doing excessive typechecking work. Change `chase_imports` (renamed to `chase_imports_cached`) to use the cache on valid files. Recreate `chase_imports` to use `chase_imports_cached` but ignoring the cache. Expose these changes in `parseMotokoTyped`. Create `parseMotokoWithDeps` that is like `parseMotoko` but also returns immediate dependencies.
GoPavel
changed the title
GoPavel
changed the title
This was referenced Mar 4, 2025
Problem: We need to pass the filename to the import resolver, which requires passing the filename to `parseMotokoWithDeps`. Solution: Accept the file name and pass it to `resolve`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve the performance of the LSP server we need to be able to cache and pass cached the type checking context (
Scope.t). It's helpful in two situations:mo:base) is parsed and type-checked as many times as it's imported (transitively) in any other file. Caching fixes this by allowing dependency type information to be reused.Changes:
src/pipeline/load_progs_cached/chase_imports_cachedthat are likeload_progs/chase_importsbut also take the scope cache and populates it. Note, expiring logic is implemented in the TS part of the server, see adjoint MR: Benchmarks & Dependecies' types caching (Serokell, Milestone-1) vscode-motoko#329).src/js(IDE API)parseMotokoTyped pathswhich returns typed AST withparseMotokoTyped path scopeCachewhich returns typed AST and updatedscopeCacheparseMotokoWithDepswhich is likeparseMotokobut also returns a list of immediate importsSee also interface changes in the
node-motoko: dfinity/node-motoko#113