Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ docker-in-docker ] - buildx can fallback to previous version if latest artifact not found #869

Conversation

gauravsaini04
Copy link
Contributor

@gauravsaini04 gauravsaini04 commented Feb 18, 2024

Feature name:

  • Docker-in-Docker

Description:

This PR introduces the following feature:

  • docker/buildx plugin can fallback to previous version in case of latest tag artifact release not found;

Changelog:

  • Updated install.sh file
    • Introduced a new flag fallback for testing this new feature
    • Code written for fallback to prev. version in case of latest artifact release not found
  • Added a scenario in scenarios.json and a corresponding test scenario docker_build_fallback_buildx

Command for testing:

devcontainer features test . -f docker-in-docker --skip-autogenerated --filter "docker_build_fallback_buildx" --preserve-test-containers

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR makes sense, thanks for looking at it. Left few comments!

src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
@gauravsaini04 gauravsaini04 marked this pull request as ready for review February 22, 2024 10:22
@gauravsaini04 gauravsaini04 requested a review from a team as a code owner February 22, 2024 10:22
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⚡

@samruddhikhandale samruddhikhandale merged commit 403c896 into devcontainers:main Feb 22, 2024
111 checks passed
@gauravsaini04 gauravsaini04 deleted the docker-in-docker_buildx_fallback branch February 23, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants