-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ docker-in-docker ] - buildx can fallback to previous version if latest artifact not found #869
Merged
samruddhikhandale
merged 7 commits into
devcontainers:main
from
gauravsaini04:docker-in-docker_buildx_fallback
Feb 22, 2024
Merged
[ docker-in-docker ] - buildx can fallback to previous version if latest artifact not found #869
samruddhikhandale
merged 7 commits into
devcontainers:main
from
gauravsaini04:docker-in-docker_buildx_fallback
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliekens
reviewed
Feb 20, 2024
samruddhikhandale
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR makes sense, thanks for looking at it. Left few comments!
samruddhikhandale
requested changes
Feb 22, 2024
samruddhikhandale
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ⚡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature name:
Description:
This PR introduces the following feature:
docker/buildx
plugin can fallback to previous version in case of latest tag artifact release not found;Changelog:
fallback
for testing this new featurescenarios.json
and a corresponding test scenariodocker_build_fallback_buildx
Command for testing:
devcontainer features test . -f docker-in-docker --skip-autogenerated --filter "docker_build_fallback_buildx" --preserve-test-containers