docker-in-docker: buildx release not found

[sliekens]

Hi,

There is a temporary problem with buildx where the tag for v0.10.5 was pushed, but the corresponding release was not.

As a result, this line is failing:

features/src/docker-in-docker/install.sh

Line 323 in b48d870

cd /tmp && wget "https://github.com/docker/buildx/releases/download/v${buildx_version}/${buildx_file_name}"

Logs:

#0 21.79 (*) Installing buildx 0.10.5...
#0 21.79 --2023-05-22 21:46:46--  https://github.com/docker/buildx/releases/download/v0.10.5/buildx-v0.10.5.linux-amd64
#0 21.80 Resolving github.com (github.com)... 140.82.121.4
#0 21.80 Connecting to github.com (github.com)|140.82.121.4|:443... connected.
#0 21.86 HTTP request sent, awaiting response... 404 Not Found
#0 22.04 2023-05-22 21:46:46 ERROR 404: Not Found.
#0 22.04 
#0 22.04 ERROR: Feature "Docker (Docker-in-Docker)" (ghcr.io/devcontainers/features/docker-in-docker) failed to install! Look at the documentation at https://github.com/devcontainers/features/tree/main/src/docker-in-docker for help troubleshooting this error.

[sliekens]

This is now resolved but it took about 5 hours for the release to catch up.

[samruddhikhandale]

Thanks for reporting the issue.

We should add some fallback to older releases if the latest tag does not exist or add a similar logic to #318

[hpe-ykoehler]

Same is occuring with v0.11.0

The issue is on the devcontainer feature, using the tags to assume that the tarball is available is a bad process as it can leads to such error.

The devcontainer feature should allow us to control the version of buildx or use the latest tarball available (not the latest tag).

For example instead of a "boolean" to enable/disable buildx, set it as a string with None as a possible value to not install it, otherwise a version string such as "latest" or let us specify a specific version, please.

[pamelafox]

I think I may be seeing the same issue? I'm trying to use docker-in-docker in a dev container on GitHub Codespaces today, and getting:

2023-06-15 00:01:44.309Z: #20 7.281 Err:5 https://packages.microsoft.com/repos/microsoft-debian-bookworm-prod bookworm Release
#20 7.281   404  Not Found [IP: 13.93.152.112 443]
#20 7.295 Reading package lists...2023-06-15 00:01:44.760Z: 
#20 7.754 E: The repository 'https://packages.microsoft.com/repos/microsoft-debian-bookworm-prod bookworm Release' does not have a Release file.
#20 7.755 ERROR: Feature "Docker (Docker-in-Docker)" (ghcr.io/devcontainers/features/docker-in-docker) failed to install! Look at the documentation at https://github.com/devcontainers/features/tree/main/src/docker-in-docker for help troubleshooting this error.
2023-06-15 00:01:44.812Z: #20 ERROR: executor failed running [/bin/sh -c chmod -R 0755 /tmp/dev-container-features/docker-in-docker_1 && cd /tmp/dev-container-features/docker-in-docker_1 && chmod +x ./devcontainer-features-install.sh && ./devcontainer-features-install.sh]: exit code: 100
------
 > [dev_containers_target_stage 5/5] RUN chmod -R 0755 /tmp/dev-container-features/docker-in-docker_1 && cd /tmp/dev-container-features/docker-in-docker_1 && chmod +x ./devcontainer-features-install.sh && ./devcontainer-features-install.sh:
------
executor failed running [/bin/sh -c chmod -R 0755 /tmp/dev-container-features/docker-in-docker_1 && cd /tmp/dev-container-features/docker-in-docker_1 && chmod +x ./devcontainer-features-install.sh && ./devcontainer-features-install.sh]: exit code: 100
2023-06-15 00:01:44.814Z: ERROR: Service 'app' failed to build : Build failed

[samruddhikhandale]

The issue is on the devcontainer feature, using the tags to assume that the tarball is available is a bad process as it can leads to such error.

Hi @hpe-ykoehler 👋

I totally agree with change, and we are aware of this problem and have this item added to the backlog. However, very busy with other items.

We appreciate contributions from the community, if you are interested and willing to open a PR with the changes, we will be glad. I can help review and provide any other support/guidance if needed.

[samruddhikhandale]

Hi @pamelafox 👋

I wonder if Microsoft repos have added support for docker-in-docker for debian:bookworm. Have you looked at devcontainers/images#607 ? Switching the image to use debian:bullseye should help in the meanwhile.

[hpe-ykoehler]

From the buildx side, they recommended using the GitHub release API. Now that is not something I am familiar with, maybe supporting a version instead of a boolean is more in my league. Will see if I can find some time.

[bseth15]

This is happening again, DinD is looking for v0.12.0 and v0.11.2 is the latest release on github.

[gauravsaini04]

Raised PR #869 for resolution

[gauravsaini04]

Important

PR #869 was merged.

[samruddhikhandale]

Closing as completed with #869