Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic notification flow #78

Merged
merged 6 commits into from
Dec 12, 2024
Merged

add basic notification flow #78

merged 6 commits into from
Dec 12, 2024

Conversation

r10s
Copy link
Member

@r10s r10s commented Dec 11, 2024

@adbenitez @ALL is that what we we want notifications to be like atm?

i am esp. unsure about the is_group condition.

i am creating this PR as i am about to implement the mention toggle on iOS at deltachat/deltachat-ios#2434 - and from the android source code, things are not really obvious, so it seems better to discuss that in some pseudo code first

feel free to commit to this PR, i think it is best to discuss that on code level base (maybe AI can generate a flowchart from that, i tried out some apps for that, but that all cost too much time :)

@r10s r10s force-pushed the notification-flow branch from 19bd8ce to 5418895 Compare December 11, 2024 17:17
@adbenitez
Copy link
Member

adbenitez commented Dec 11, 2024

i am esp. unsure about the is_group condition.

it is not "is_group" but "is_multiuser" basically anything that is not a 1:1 since in a 1:1 every message is a direct mention to you, you are the explicit target of every message and that is what mentions are really about, and if you muted the chat that means you are muting all the messages there that are all mentions, it wouldn't make sense to bypass chat muting by mentioning in 1:1

notification-flow.md Outdated Show resolved Hide resolved
notification-flow.md Outdated Show resolved Hide resolved
@adbenitez
Copy link
Member

diagram2

@Hocuri
Copy link
Contributor

Hocuri commented Dec 12, 2024

LGTM.

I actually find the pseudocode easier to read than the flow chart.

@r10s
Copy link
Member Author

r10s commented Dec 12, 2024

I actually find the pseudocode easier to read than the flow chart

yip - esp. when yes/no lines have different directions, these flow charts easily get a mess.
also, it is easier to adapt, a flowchart created by some tool gets easily outdated.

for non-devs, that may be easier to understand

however, i merge this in as is, without source code or instructions, the flowchart does not become part of the repo then, but that seems fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants