-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic notification flow #78
Conversation
19bd8ce
to
5418895
Compare
it is not "is_group" but "is_multiuser" basically anything that is not a 1:1 since in a 1:1 every message is a direct mention to you, you are the explicit target of every message and that is what mentions are really about, and if you muted the chat that means you are muting all the messages there that are all mentions, it wouldn't make sense to bypass chat muting by mentioning in 1:1 |
LGTM. I actually find the pseudocode easier to read than the flow chart. |
Co-authored-by: adb <[email protected]>
Co-authored-by: adb <[email protected]>
yip - esp. when yes/no lines have different directions, these flow charts easily get a mess. for non-devs, that may be easier to understand however, i merge this in as is, without source code or instructions, the flowchart does not become part of the repo then, but that seems fine :) |
@adbenitez @ALL is that what we we want notifications to be like atm?
i am esp. unsure about the
is_group
condition.i am creating this PR as i am about to implement the mention toggle on iOS at deltachat/deltachat-ios#2434 - and from the android source code, things are not really obvious, so it seems better to discuss that in some pseudo code first
feel free to commit to this PR, i think it is best to discuss that on code level base (maybe AI can generate a flowchart from that, i tried out some apps for that, but that all cost too much time :)